Fix testGH902_whenTypeReferenceIsUnknownButQualified_expectToBeFound #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not suggest methods from enclosing types after `super.|` - These completions should count as NON_STATIC - These completion should not count as either QUALIFIED or UNQUALIFIED Fixes 1 case Signed-off-by: David Thompson <[email protected]>
…ture) - Fix calculation of signature of expected types in completion context. It wasn't handling inner types properly. - use our method from `SignatureUtils` to handle this - Handle "start of constructor" token location calculation (also related to completion context) Fixes 3 Signed-off-by: David Thompson <[email protected]>
- Don't complete enum constant declarations - Better handling of completion of qualified `super` and `this` (take into account if you're in an interface) - Improve `JavacConverter` to handle "field access" split across two lines as in `CompletionTests.testBug573632` (signatures don't match properly so it's not passing) Should fix 4 and improve many more Signed-off-by: David Thompson <[email protected]>
Fixes 1 test case Signed-off-by: David Thompson <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Fixes eclipse-jdt#1629 Signed-off-by: David Thompson <[email protected]>
Fixes eclipse-jdt#1630 , fixes 1 test case Signed-off-by: David Thompson <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Also fix DOMVariableBinding.isParameter() for caught Exception
Another portion of the fix depended on addressing eclipse-jdt#4247, which is now resolved Signed-off-by: David Thompson <[email protected]>
There are other issues that arise when having a `module-info.java` in a Java 8 project, but this makes sure that we at least don't try to convert the AST nodes, which prevents an exception. Fixes eclipse-jdt#193 Signed-off-by: David Thompson <[email protected]>
Record components are often modeled as ILocalVariable, which might use different parent in a case or another. Instead of strictly checking for equal model element, we check that they are equivalent (name and position)
eg. after `|`
```java
public class CompleteInInstanceof {
public void myMethod() {
Object o = null;
boolean a = o instanceof RequiresDirective requires && useRequiresDirective(req|);
}
static class RequiresDirective {
private int a;
public RequiresDirective(int a) { this.a = a; }
int getA() { return a; }
}
public static boolean useRequiresDirective(RequiresDirective requiresDirective) {
return requiresDirective.getA() > 5;
}
}
```
Fixes eclipse-jdt#1593
Signed-off-by: David Thompson <[email protected]>
Signed-off-by: Rob Stryker <[email protected]> Fix regressions Signed-off-by: Rob Stryker <[email protected]> Fix issues with patch Signed-off-by: Rob Stryker <[email protected]> Fix obvious error Signed-off-by: Rob Stryker <[email protected]> Fix regression in testMethodReference14 Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
No need to compute this info as model manager already has it.
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]> Attempt to fix regression testBug110336d Signed-off-by: Rob Stryker <[email protected]>
Cool. Did you submit a PR upstream too? As it's in a "new" and non-covered-by-default execution path, we may be lucky enough to get it merged for next RC1... |
…SearchGenericMethodEquivalentTests Signed-off-by: Rob Stryker <[email protected]> Fix regressions Signed-off-by: Rob Stryker <[email protected]> Fix regressions Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…er04 in equivalent tests Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Author
|
Was fixed here: eclipse-jdt#4600 We still need to rebase. |
|
Rebasing on top of upstream master is usually not necesary, the artifacts from latest I-Build are used (we usually do not rebuild org.eclipse.jdt.core). However, in this release transition period, things could be indeed more complex: is parent pom pointing to the right repo? is the I-Build containing the upstream fix?... |
Signed-off-by: Rob Stryker <[email protected]>
mickaelistria
force-pushed
the
testGH902_whenTypeReferenceIsUnknownButQualified_expectToBeFound
branch
from
a216ada to
6f1e0ae
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
411dfec to
ac3eb19
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
5738537 to
9962d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.