Skip to content

Updated can protocol adapter description in readme#20

Merged
SebastianSchildt merged 1 commit intoeclipse-kuksa:mainfrom
ManjukiranVALEO:can-protocol-adapter-readme_update
Feb 19, 2025
Merged

Updated can protocol adapter description in readme#20
SebastianSchildt merged 1 commit intoeclipse-kuksa:mainfrom
ManjukiranVALEO:can-protocol-adapter-readme_update

Conversation

@ManjukiranVALEO
Copy link
Contributor

Updated Readme file with new content can-protocol-adapter

@RaviprasadBS
Copy link
Contributor

@lukasmittag @SebastianSchildt can you please review the PL which is created to update the can-protocol-adapter module name in ReadMe.md file?

@SebastianSchildt
Copy link
Contributor

Hi, there is still an issue with the Eclipse Comitter Agreement. Basically the authir @ManjukiranVALEO needs to create an Eclipse account (free) at https://www.eclipse.org and "agree" (a check mark int he profile) to the Eclispe Comitter Agreement AND add the Github handle ManjukiranVALEO to the Eclipse Account as well.

Then this check should become green

@SebastianSchildt
Copy link
Contributor

Then change itself is looking good, but we can only merge once the ECA check becomes green

@ManjukiranVALEO
Copy link
Contributor Author

@SebastianSchildt, thanks for the information, I have linked my GitHub handle to eclipse account and the ECA check is green now.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 🔉

@SebastianSchildt SebastianSchildt merged commit 0e8261c into eclipse-kuksa:main Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants