Skip to content

add kuksa-cpp-client#22

Merged
SebastianSchildt merged 3 commits intoeclipse-kuksa:mainfrom
AkhilTThomas:feat/add-kuksa-cpp-client
Feb 28, 2025
Merged

add kuksa-cpp-client#22
SebastianSchildt merged 3 commits intoeclipse-kuksa:mainfrom
AkhilTThomas:feat/add-kuksa-cpp-client

Conversation

@AkhilTThomas
Copy link
Contributor

A C++ based client interfacing with kuksa data broker using V1 and V2 API is added.
@SebastianSchildt @nayakned

@SebastianSchildt
Copy link
Contributor

Hi @AkhilTThomas , cool this is landing here. I warned you about Linters :D

Pre-commit is unhappy. See here https://github.com/eclipse-kuksa/kuksa-incubation?tab=readme-ov-file#pre-commit-set-up how to set up and see the thread/comment here #18 (comment) how to repair

@AkhilTThomas
Copy link
Contributor Author

Hi @AkhilTThomas , cool this is landing here. I warned you about Linters :D

Pre-commit is unhappy. See here https://github.com/eclipse-kuksa/kuksa-incubation?tab=readme-ov-file#pre-commit-set-up how to set up and see the thread/comment here #18 (comment) how to repair

Yes! Surprisingly the pre-commit is not complaining locally. Might be conflicting with the ones i had in my repo.

@AkhilTThomas AkhilTThomas force-pushed the feat/add-kuksa-cpp-client branch from 81978d3 to 230d6e1 Compare February 26, 2025 21:38
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation about what from v2 is supported by this cpp client would be nice. For example the bi directional streaming part is not supported.

Establish connection to a databroker end-point
- `get("Vehicle.Speed")`
Get a datapoint value
- `set("Vehicle.Speed",value)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be called publish due to the terminology of kuksa.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified this and added better documentation

- Added doc strings for v2 APIs
- Support getServerInfo
- Support getValues
- Extend v2 examples
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianSchildt
Copy link
Contributor

Merging this. Hoping for more updates in the future :D

@SebastianSchildt SebastianSchildt merged commit 571fe04 into eclipse-kuksa:main Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants