Merged
Conversation
dhuebner
force-pushed
the
dhuebner/document-analyzer
branch
from
954dcc3 to
2d83231
Compare
montymxb
approved these changes
Nov 24, 2025
Contributor
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
Approved 
! This looks really good, just one question about the Gini index calculation, but overall looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we need the document when analyzing rules usage I moved document creation to an abstract
AbstractDocumentEvaluatorclass that also handle Document build failure.Existing
LangiumEvaluatornow implements abstractevaluateDocument()method. Otherwise everything works as before.If the use now wants to collect usage statistic it can use the new
LangiumDocumentAnalyzerthat extendsLangiumEvaluator. In theevaluateDocumentthe evaluation resultEvaluatorResultwill be enriched with additionalsyntax_statisticsdata.Overall I'm not quite satisfied with the existing evaluation API. I think we need a possibility to register Evaluators that work with Langium documents directly. Otherwise we will probably build same document several times or maintain the documents state in document related evaluators.