Add documentation for profiling #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Rudolph <[email protected]>
Signed-off-by: Markus Rudolph <[email protected]>
|
msujew
reviewed
Nov 5, 2025
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Looks quite good. See the comment below for the open TODO item.
| └─────────┴───────────────────────────────┴───────┴────────┴───────────┘ | ||
| ``` | ||
|
|
||
| * the **validation** process broken down by each grammar rule. TODO what exactly is measured here? |
Member
There was a problem hiding this comment.
During the validation, the profiler measures the time each type of AST node takes to go through the validation. Count will keep track of how many nodes of a specific type have been validated. In this example, 5 Person items and 8 Greeting items have gone through the validation, taking 60% and 8% of the whole validation time respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284
There is one TODO, I cannot resolve: What do we measure in the validation phase?