Merge inferred array types #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotes
requested changes
Jun 5, 2024
Contributor
Lotes
left a comment
Lotes
left a comment
There was a problem hiding this comment.
Thanks for the change :-). Two remarks about code duplication and immutable operations.
packages/langium/src/grammar/type-system/type-collector/plain-types.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1505
Note that this approach has a very minor issue in regards to alternatives of lists:
The expected type would be
values: Array<string> | Array<number>, but this PR adjusts this to generatevalues: Array<string | number>. I think this is "good enough" as it fixes the much more common issue ofvalues+=ID values+=NUMBER. See also eclipse-langium/langium-website#132 (comment).