Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Jul 9, 2025

... and one less cyclic dependency to CDT 👍

@jjohnstn as discussed in the CDT monthly call:

FYI @jonahgraham @akurtakov

@laeubi laeubi force-pushed the update_terminal branch from 2fe67a6 to 7a4ab5d Compare July 9, 2025 16:07
@laeubi
Copy link
Contributor Author

laeubi commented Jul 9, 2025

CDT uses https://download.eclipse.org/linuxtools/updates-docker-nightly so I would suspect this change to become visible once this is merged the next day also to cdt...

@akurtakov
Copy link
Contributor

Looks like you forgot to add code changes in vagrant plugin.

@laeubi laeubi force-pushed the update_terminal branch 2 times, most recently from 1f5fbf3 to e3a5d65 Compare July 9, 2025 17:44
@laeubi
Copy link
Contributor Author

laeubi commented Jul 9, 2025

Looks like you forgot to add code changes in vagrant plugin.

Should be fixed now, please wait before merging this before we have decided on this one:

I should then replace the require-bundle by import packages as well, but first let this get compiled :-)

@akurtakov
Copy link
Contributor

Ok, I'll wait for your GO before merging it in.

@laeubi
Copy link
Contributor Author

laeubi commented Jul 9, 2025

For some reason now Jenkins do not like to pickup the change :-\

@laeubi laeubi force-pushed the update_terminal branch 3 times, most recently from dca26b1 to 31d8426 Compare July 13, 2025 03:53
@laeubi laeubi force-pushed the update_terminal branch from 31d8426 to 21d4f14 Compare July 16, 2025 05:08
@laeubi
Copy link
Contributor Author

laeubi commented Jul 16, 2025

@akurtakov I think the API has stabilized enough for this to be merged!

@ruspl-afed if this is merged and we need further adjustments, please make sure to update linuxtools accordingly once the new I-Builds are available.

@ruspl-afed
Copy link

@akurtakov I think the API has stabilized enough for this to be merged!

The only change I plan for ITerminalService is to stop accepting null as Done callback and provide standard empty implementation eclipse-platform/eclipse.platform#2051
All the rest of signatures and arguments looks good for now.

@ruspl-afed
Copy link

@laeubi Done-related API change eclipse-platform/eclipse.platform#2051 has been merged

@akurtakov akurtakov merged commit 6235aa5 into eclipse-linuxtools:master Jul 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants