Adapt LSP4E to LSP4J vers. 1.0.0 #1421
Draft
+43
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travkin79
force-pushed
the
feature/lsp4j-1
branch
from
47ec245 to
fdcf0fd
Compare
Member
|
We should hold merging this back until LSP4J 1.0 is actually released otherwise we are blocked from cutting LSP4E releases ourselves from now on. |
Contributor
Author
|
Hi @sebthom,
I expected that. Would you prefer to change this PR's status to draft? |
Member
|
I think that is appropriate for now. |
jonahgraham
approved these changes
Nov 25, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
This LGTM - I have done code inspection, but not run it up in LSP4E.
travkin79
force-pushed
the
feature/lsp4j-1
branch
from
e82e0c6 to
d227f85
Compare
For the sake of simplicity, for now, we only use the left argument in Either tuples, i.e. the types that we used in earlier versions.
travkin79
force-pushed
the
feature/lsp4j-1
branch
from
d227f85 to
ee645ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt LSP4E to LSP4J API changes as suggested by @jonahgraham. Other PRs requiring LSP4J vers. 1.0.0 like PR #1149 will base upon changes from this PR.