Skip to content

feat: improve response error exception logs #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenporras merged 1 commit into from
Dec 17, 2025
Merged

feat: improve response error exception logs #1473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/LanguageServerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,15 @@
import org.eclipse.jface.resource.ImageRegistry;
import org.eclipse.jface.text.BadLocationException;
import org.eclipse.lsp4e.ui.LSPImages;
import org.eclipse.lsp4j.jsonrpc.ResponseErrorException;
import org.eclipse.lsp4j.jsonrpc.messages.ResponseError;
import org.eclipse.ui.plugin.AbstractUIPlugin;
import org.osgi.framework.BundleContext;

import com.google.common.base.Throwables;
import com.google.common.hash.HashCode;
import com.google.common.hash.Hashing;
import com.google.gson.JsonPrimitive;

public class LanguageServerPlugin extends AbstractUIPlugin {

Expand Down Expand Up @@ -110,7 +113,21 @@ public static void logError(final @Nullable String message, final @Nullable Thro
return;
EXCEPTIONS_COUNTER.compute(key, (k, v) -> v == null ? 1 : ++v);
}
plugin.getLog().log(new Status(IStatus.ERROR, PLUGIN_ID, 0, message, thr));

logThrowable(message, IStatus.ERROR, thr, plugin);
}
}

private static void logThrowable(final @Nullable String message, final int status, final @Nullable Throwable thr, final LanguageServerPlugin plugin) {
if (thr != null && thr.getCause() instanceof ResponseErrorException ree) {
ResponseError responseError = ree.getResponseError();
if (responseError.getData() instanceof JsonPrimitive p) {
plugin.getLog().log(new Status(status, PLUGIN_ID, responseError.getMessage() + '(' + responseError.getCode() + ')' + '\n' + p.getAsString()));
} else {
plugin.getLog().log(new Status(status, PLUGIN_ID, responseError.toString()));
}
} else {
plugin.getLog().log(new Status(status, PLUGIN_ID, 0, message, thr));
}
}

Expand Down Expand Up @@ -145,7 +162,7 @@ public static void logWarning(final @Nullable String message) {
*/
public static void logWarning(final @Nullable String message, final @Nullable Throwable thr) {
if (plugin != null) {
plugin.getLog().log(new Status(IStatus.WARNING, PLUGIN_ID, 0, message, thr));
logThrowable(message, IStatus.WARNING, thr, plugin);
}
}

Expand Down
Loading