Skip to content

Conversation

@G-Ork
Copy link
Contributor

@G-Ork G-Ork commented Feb 18, 2024

I redesigned the Maven user settings and add the sections Global & User. For booth there are now settings & toolchains options.

  • Added default path hints for global settings and global toolchains. They are only rendered for external maven installations. Don't forget to apply changes to see them.
  • Unify settings override through goals field. All four settings could be put into the goal in short form (-gt. -gs, -t, -s).
  • Throw exception during launch if path to a settings file is invalid.
  • Provide unit-tests for maven launcher for all four settings
  • Fix a bug in settings validation. Parser problems are not copied to result if parser do not crash. All well formed xml-files are treated as valid.
Maven-Usersettings-Draft

- cleanup user settings dialog
- Fix settings validation
- add missing XSDs to eclipse XML catalog contribution
- provide unit test for maven launcher
…@github.com:G-Ork/m2e-core.git into Maven_global_settings_and_toolchains_UI_cleanup
Maven_global_settings_and_toolchains_UI_cleanup
@github-actions
Copy link

github-actions bot commented Feb 18, 2024

Test Results

0 files   -   214  0 suites   - 214   0s ⏱️ - 22m 41s
0 tests  -   665  0 ✅  -   655  0 💤  - 10  0 ❌ ±0 
0 runs   - 1 330  0 ✅  - 1 308  0 💤  - 22  0 ❌ ±0 

Results for commit 195f29e. ± Comparison against base commit a680216.

♻️ This comment has been updated with latest results.

@G-Ork G-Ork force-pushed the Unified_UI_Setting_for_Toolchains branch from df11ec9 to 7f2d136 Compare March 20, 2024 15:58
@G-Ork G-Ork force-pushed the Unified_UI_Setting_for_Toolchains branch from 7f2d136 to 195f29e Compare March 20, 2024 16:04
@akurtakov
Copy link
Contributor

Is there interest if finishing this one?

@laeubi
Copy link
Member

laeubi commented Feb 21, 2025

@G-Ork can you pleas squash all commits and rebase on main?

@G-Ork
Copy link
Contributor Author

G-Ork commented Feb 21, 2025

I'll do my best to squeeze the squash it into this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants