Skip to content

Extract maven-resolver-api from the embedded runtime bundle #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Extract maven-resolver-api from the embedded runtime bundle #1770

wants to merge 1 commit into from
+14 −2

Conversation

@laeubi
Copy link
Member

@laeubi laeubi commented Jun 1, 2024 •
edited
Loading

Currently we embed the maven-resolver-api jar into m2e, but the API itself is already a bundle an we should consume it as such so we can:

  1. update it independently
  2. make it reusable by others without require the full runtime
  3. cut down the size of the runtime bundle

@github-actions
Copy link

github-actions bot commented Jun 1, 2024 •
edited
Loading

Test Results

0 files   -   321  0 suites   - 321   0s ⏱️ - 52m 31s
0 tests  -   683  0 ✅  -   661  0 💤  - 20  0 ❌  - 1 
0 runs   - 2 049  0 ✅  - 1 987  0 💤  - 60  0 ❌  - 1 

Results for commit 582e923. ± Comparison against base commit 19c8f09.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the extract_resolver_api branch from 08a84f8 to 4211ad1 Compare June 1, 2024 15:20
HannesWell
HannesWell reviewed Jun 2, 2024
View reviewed changes
Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try that, but I would be in favor to do it after the upcoming release for the 24-06 SimRel.
I have no clue if maven-core works that well if the resolve is not on the same flat classpath.
The bundle has indeed OSGi metadata, but I would be (positively) surprised if everything works already.

@laeubi laeubi force-pushed the extract_resolver_api branch from 4211ad1 to b59ae06 Compare June 3, 2024 05:13
@laeubi
Copy link
Member Author

laeubi commented Jun 3, 2024 •
edited
Loading

We can try that, but I would be in favor to do it after the upcoming release for the 24-06 SimRel.

I marked this as draft as it is more an experiment now :-)
So if it can work I see no problem in delay it to the next cycle.

I have no clue if maven-core works that well if the resolve is not on the same flat classpath.

I don't think its a big issue as its all only API, but realized that this will require to change all bundles previously requiring maven.runtime, I therefore changed it not to a require-bundle with reexport.

@laeubi laeubi force-pushed the extract_resolver_api branch 2 times, most recently from a604c4c to 8b8001b Compare June 3, 2024 05:43
@laeubi laeubi mentioned this pull request Jun 3, 2024
Closed
@laeubi laeubi force-pushed the extract_resolver_api branch 2 times, most recently from a467b14 to 9df7271 Compare June 3, 2024 06:50
@laeubi laeubi force-pushed the extract_resolver_api branch from 9df7271 to 8d299fd Compare February 21, 2025 09:09
@laeubi
Extract maven-resolver-api from the embedded runtime bundle
582e923 
Currently we embed the maven-resolver-api jar into m2e, but the API
itself is already a bundle an we should consume it as such so we can:

1) update it independently
2) make it reusable by others without require the full runtime
3) cut down the size of the runtime bundle
@laeubi laeubi force-pushed the extract_resolver_api branch from 8d299fd to 582e923 Compare February 21, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HannesWell HannesWell HannesWell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laeubi @HannesWell