Skip to content

Conversation

@kwin
Copy link
Member

@kwin kwin commented Oct 20, 2025

Similar to what is done for the Maven Launch Configurations. Move logic for Maven Execution JRE to org.eclipse.m2e.jdt.

This closes #2059

@kwin kwin force-pushed the feature/maven-execution-jre-for-tests branch from ae35520 to 2c8b9be Compare October 20, 2025 16:30
@eclipse-m2e-bot
Copy link
Contributor

eclipse-m2e-bot commented Oct 20, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.m2e.feature/feature.xml
org.eclipse.m2e.sdk.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 769fe460fa47b384ffa64996bffea5234477a007 Mon Sep 17 00:00:00 2001
From: Eclipse M2E Bot <[email protected]>
Date: Tue, 21 Oct 2025 08:42:20 +0000
Subject: [PATCH] Version bump(s) for null object or invalid expression stream


diff --git a/org.eclipse.m2e.feature/feature.xml b/org.eclipse.m2e.feature/feature.xml
index e153e1f1..b637f8d3 100644
--- a/org.eclipse.m2e.feature/feature.xml
+++ b/org.eclipse.m2e.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.m2e.feature"
       label="%featureName"
-      version="2.9.200.qualifier"
+      version="2.10.0.qualifier"
       provider-name="%providerName"
       plugin="org.eclipse.m2e.core"
       license-feature="org.eclipse.license"
diff --git a/org.eclipse.m2e.sdk.feature/feature.xml b/org.eclipse.m2e.sdk.feature/feature.xml
index 97dca0c3..a19f245c 100644
--- a/org.eclipse.m2e.sdk.feature/feature.xml
+++ b/org.eclipse.m2e.sdk.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.m2e.sdk.feature"
       label="%featureName"
-      version="2.9.200.qualifier"
+      version="2.10.0.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Test Results

  327 files  +3    327 suites  +3   1h 3m 7s ⏱️ - 8m 49s
  692 tests ±0    668 ✅  - 2  21 💤 ±0  1 ❌ +1  2 🔥 +1 
2 076 runs  ±0  2 010 ✅  - 2  63 💤 ±0  1 ❌ +1  2 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit a162b17. ± Comparison against base commit 27eae6a.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both.
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_1XversionRange
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_9versionRange
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_majorOnly
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_rangeWithOnlyMajorLowerBound
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_versionRangeWithNoMajorVersionMatch
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_1XversionRange
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_9versionRange
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_majorOnly
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_rangeWithOnlyMajorLowerBound
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_versionRangeWithNoMajorVersionMatch

♻️ This comment has been updated with latest results.

@kwin kwin force-pushed the feature/maven-execution-jre-for-tests branch from faf973e to aad9c65 Compare October 21, 2025 08:36
Similar to what is done for the Maven Launch Configurations.
Move logic for Maven Execution JRE to org.eclipse.m2e.jdt.

This closes #2059
@kwin kwin force-pushed the feature/maven-execution-jre-for-tests branch from aad9c65 to ae10f7a Compare October 21, 2025 08:37
@kwin kwin requested review from HannesWell and laeubi October 21, 2025 09:22
Add release notes entry
@kwin kwin force-pushed the feature/maven-execution-jre-for-tests branch from 9d3934c to a162b17 Compare October 21, 2025 09:40
@kwin kwin marked this pull request as ready for review October 21, 2025 09:56
@kwin
Copy link
Member Author

kwin commented Oct 30, 2025

@laeubi @HannesWell Any concerns with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnitTestSupport should set JRE to Maven Execution JRE (same as Maven Launches)

3 participants