[Fix #138] Avoid SnapshotImpl.getObject HeapObjectCache thrashing in getRetainedHeapTopConsumersDescription #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rashing in getRetainedHeapTopConsumersDescription Signed-off-by: Kevin Grigorenko <[email protected]>
Member
Author
|
@jasonk000 @krumts Please review if you have a chance or otherwise I'll commit in a few weeks. This was tested within IBM and the user confirmed the fix. All tests pass locally. |
jasonk000
approved these changes
Aug 20, 2025
| IObject object = snapshot.getObject(objectId); | ||
| String name = snapshot.isClass(objectId) ? ((IClass) object).getName() : object.getClazz().getName(); | ||
|
|
||
| result.append(MessageUtil.format( |
| Set<Entry<Integer, Long>> entries = sumHeapSizes.entrySet(); | ||
| boolean multipleItems = entries.size() > 1 && topItems > 1; | ||
| PriorityQueue<Entry<String, Long>> pq = new PriorityQueue<Entry<String, Long>>(entries.size(), | ||
| PriorityQueue<Entry<Integer, Long>> pq = new PriorityQueue<Entry<Integer, Long>>(entries.size(), |
Contributor
There was a problem hiding this comment.
In hindsight, wondering if you found this PQ better than a sort?
Comment on lines
+635
to
+636
| Map<Integer, Long> sumHeapSizes = new HashMap<>(); | ||
| Map<Integer, Integer> counts = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
We also have org.eclipse.mat.collect.HashMapIntLong as an option, to avoid the boxing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138