More precise constness for topics in mosquitto_subscribe_multiple#3199
Open
niklasf wants to merge 1 commit intoeclipse-mosquitto:fixesfrom
Open
More precise constness for topics in mosquitto_subscribe_multiple#3199niklasf wants to merge 1 commit intoeclipse-mosquitto:fixesfrom
niklasf wants to merge 1 commit intoeclipse-mosquitto:fixesfrom
Conversation
mosquitto_subscribe_multiple and mosquitto_unsubscribe_multiple do not need to change the characters in the list of topics. Make the signature more precise to reflect that. Now works without cast array of const char*, particularly useful for C++ or Rust bindings. Signed-off-by: Niklas Fiekas <niklas.fiekas@backscattering.de>
niklasf
commented
Jan 11, 2025
| connack_result = result; | ||
| if(!result){ | ||
| mosquitto_subscribe_multiple(mosq, NULL, cfg.topic_count, cfg.topics, cfg.qos, cfg.sub_opts, cfg.subscribe_props); | ||
| mosquitto_subscribe_multiple(mosq, NULL, cfg.topic_count, (const char* const*)cfg.topics, cfg.qos, cfg.sub_opts, cfg.subscribe_props); |
Author
There was a problem hiding this comment.
Unfortunately C (unlike C++) also warns about converions from char** to const char* const*, even though the latter has lower requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mosquitto_subscribe_multipleandmosquitto_unsubscribe_multipledo not need to change the characters in the list of topics. Make the signature more precise to reflect that.Now works without cast array of
const char*, particularly useful for C++ or Rust bindings.Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
If you are contributing a new feature, is your work based off the develop branch?make testwith your changes locally?