Additional fuzz targets to improve security testing coverage#3451
Open
emptyiscolor wants to merge 1 commit intoeclipse-mosquitto:developfrom
Open
Additional fuzz targets to improve security testing coverage#3451emptyiscolor wants to merge 1 commit intoeclipse-mosquitto:developfrom
emptyiscolor wants to merge 1 commit intoeclipse-mosquitto:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 23c918ee addressed issue #3435 and introduced initial fuzz targets to improve testing coverage. This PR continues that effort by adding more fuzz targets to further increase security testing coverage for Mosquitto.
New broker fuzzers:
broker_fuzz_bridge_remap_topic_in- Tests bridge topic remapping logicbroker_fuzz_properties_to_json- Tests MQTT v5 properties to JSON conversionbroker_fuzz_property_read_all- Tests property reading/parsingbroker_fuzz_proxy_v1_decode- Tests PROXY protocol v1 decodingbroker_fuzz_subscribe- Tests subscription handlingbroker_fuzz_will_set- Tests will message settingbroker_fuzz_ws_prepare_packet- Tests WebSocket packet preparationNew dynamic-security plugin fuzzers:
dynsec_fuzz_config_from_json- Tests dynamic security config parsing from JSONdynsec_fuzz_roles_process_add_acl- Tests role ACL processingAll fuzzers follow the existing fuzzer style in the repository and include seed corpora for effective fuzzing.
Test plan
New broker fuzzers:
broker_fuzz_bridge_remap_topic_in- Tests bridge topic remapping logicbroker_fuzz_properties_to_json- Tests MQTT v5 properties to JSON conversionbroker_fuzz_property_read_all- Tests property reading/parsingbroker_fuzz_proxy_v1_decode- Tests PROXY protocol v1 decodingbroker_fuzz_subscribe- Tests subscription handlingbroker_fuzz_will_set- Tests will message settingbroker_fuzz_ws_prepare_packet- Tests WebSocket packet preparationNew dynamic-security plugin fuzzers:
dynsec_fuzz_config_from_json- Tests dynamic security config parsing from JSONdynsec_fuzz_roles_process_add_acl- Tests role ACL processingAll fuzzers follow the existing fuzzer style in the repository and include seed corpora for effective fuzzing.
Test
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?