Fix mosquitto_passwd hash types and some doc. details#3500
Open
mikini wants to merge 3 commits intoeclipse-mosquitto:developfrom
Open
Fix mosquitto_passwd hash types and some doc. details#3500mikini wants to merge 3 commits intoeclipse-mosquitto:developfrom
mikini wants to merge 3 commits intoeclipse-mosquitto:developfrom
Conversation
* with -c file is only written and must not exist * without -c file is read then written and must exist Signed-off-by: Mikkel Kirkgaard Nielsen <miki+eclipse@mikini.dk>
* use build define to set argon2id as default if enabled and switch on acceptance of argon2id type, mirror this in inline help * remove argon2id from man and indicate correct sha512-pbkdf2 default Signed-off-by: Mikkel Kirkgaard Nielsen <miki+eclipse@mikini.dk>
Signed-off-by: Mikkel Kirkgaard Nielsen <miki+eclipse@mikini.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use WITH_ARGON2 define to only set argon2id as default and accept
argon2id type if enabled (currently only possible on build cmd line)
additionally use WITH_ARGON2 to produce corresponding inline help
in doc. remove argon2id and indicate correct sha512-pbkdf2 default
in doc. and inline help correct -c overwrite wording about effect of file
existence and elaborate about expectations if not given
in doc. and inline help document -I option for sha512-pbkdf2 iterations
(observations triggered by discussion in #2915)
(based on develop as instructed fixes branch does not carry changes since
~2.0, however develop is also missing changes since 2.1.0, ie. two tagged
releases, let me know if there is a better approach)
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?