Skip to content

Fix mosquitto_passwd hash types and some doc. details#3500

Open
mikini wants to merge 3 commits intoeclipse-mosquitto:developfrom
mikini:passwd-doc-hash-type-fix
Open

Fix mosquitto_passwd hash types and some doc. details#3500
mikini wants to merge 3 commits intoeclipse-mosquitto:developfrom
mikini:passwd-doc-hash-type-fix

Conversation

@mikini
Copy link
Copy Markdown

@mikini mikini commented Feb 12, 2026

  • use WITH_ARGON2 define to only set argon2id as default and accept
    argon2id type if enabled (currently only possible on build cmd line)

  • additionally use WITH_ARGON2 to produce corresponding inline help

  • in doc. remove argon2id and indicate correct sha512-pbkdf2 default

  • in doc. and inline help correct -c overwrite wording about effect of file
    existence and elaborate about expectations if not given

  • in doc. and inline help document -I option for sha512-pbkdf2 iterations

(observations triggered by discussion in #2915)
(based on develop as instructed fixes branch does not carry changes since
~2.0, however develop is also missing changes since 2.1.0, ie. two tagged
releases, let me know if there is a better approach)


Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

* with -c file is only written and must not exist
* without -c file is read then written and must exist

Signed-off-by: Mikkel Kirkgaard Nielsen <miki+eclipse@mikini.dk>
* use build define to set argon2id as default if enabled and switch
  on acceptance of argon2id type, mirror this in inline help
* remove argon2id from man and indicate correct sha512-pbkdf2 default

Signed-off-by: Mikkel Kirkgaard Nielsen <miki+eclipse@mikini.dk>
Signed-off-by: Mikkel Kirkgaard Nielsen <miki+eclipse@mikini.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant