Fix OpenSSL config loading race condition for TLS engines#3533
Open
JackBoliangM wants to merge 1 commit intoeclipse-mosquitto:fixesfrom
Open
Fix OpenSSL config loading race condition for TLS engines#3533JackBoliangM wants to merge 1 commit intoeclipse-mosquitto:fixesfrom
JackBoliangM wants to merge 1 commit intoeclipse-mosquitto:fixesfrom
Conversation
When setting MOSQ_OPT_TLS_ENGINE, mosquitto_string_option() initializes the OpenSSL singleton via OPENSSL_init_crypto but omits the OPENSSL_INIT_LOAD_CONFIG flag. If an engine is set before mosquitto_connect_async() (which calls net__init_tls()), OpenSSL locks its initialization state without reading openssl.cnf. This causes engines like pkcs11 to fail to resolve their MODULE_PATH, resulting in dlopen failures for hardware TrustZone/HSM modules. Adding OPENSSL_INIT_LOAD_CONFIG to the engine initialization ensures the configuration is parsed and the engine can locate its dynamic backend. Signed-off-by: Jack(Boliang) Ma <jack.boliang.ma106@gmail.com>
JackBoliangM
force-pushed
the
fix-openssl-engine-config-fixes
branch
from
bbf385b to
5f98b74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting MOSQ_OPT_TLS_ENGINE, mosquitto_string_option() initializes the OpenSSL singleton via OPENSSL_init_crypto but omits the OPENSSL_INIT_LOAD_CONFIG flag.
If an engine is set before mosquitto_connect_async() (which calls net__init_tls()), OpenSSL locks its initialization state without reading openssl.cnf. This causes engines like pkcs11 to fail to resolve their MODULE_PATH, resulting in dlopen failures for hardware TrustZone/HSM modules.
Example error log (Found under release/v2.0)
Adding OPENSSL_INIT_LOAD_CONFIG to the engine initialization ensures the configuration is parsed and the engine can locate its dynamic backend.