Fix missing error code in persist read error paths#3558
Open
lonelybones wants to merge 1 commit intoeclipse-mosquitto:developfrom
Open
Fix missing error code in persist read error paths#3558lonelybones wants to merge 1 commit intoeclipse-mosquitto:developfrom
lonelybones wants to merge 1 commit intoeclipse-mosquitto:developfrom
Conversation
In persist__chunk_client_msg_read_v56() and persist__chunk_base_msg_read_v56(), three error paths jump to the error cleanup label without setting rc, causing the functions to return success (0) on malformed input. A crafted persistence file with a length underflow silently loads a corrupt message with NULL topic and payload pointers, leading to a NULL pointer dereference (SEGV) on the next persistence save. Confirmed with AddressSanitizer: SEGV in strncmp called from persist__client_messages_save during broker shutdown. Set rc to the appropriate error code before each goto. Signed-off-by: Andrew Letourneau <0xlonelybones@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In persist__chunk_client_msg_read_v56() and persist__chunk_base_msg_read_v56(), three error paths jump to the error cleanup label without setting rc, causing the functions to return success (0) on malformed input.
A crafted persistence file with a length underflow silently loads a corrupt message with NULL topic and payload pointers, leading to a NULL pointer dereference (SEGV) on the next persistence save.
Confirmed with AddressSanitizer: SEGV in strncmp called from persist__client_messages_save during broker shutdown.
Set rc to the appropriate error code before each goto.
make testwith your changes locally?