Skip to content

Conversation

Michael5601
Copy link
Contributor

@Michael5601 Michael5601 commented Apr 22, 2025

This PR adds SVGs for all icons in the bundles org.eclipse.mylyn.tasks.ui and org.eclipse.mylyn.wikitext.ui except for the following as these are not available as SVG yet:

org.eclipse.mylyn.wikitext.ui/org.eclipse.mylyn.internal.wikitext.ui.util.resources/missing-image.svg

See also this PR for more information.

@Michael5601 Michael5601 force-pushed the org.eclipse.mylyn.SVGs branch from 168563d to aada70e Compare April 22, 2025 12:06
@ruspl-afed
Copy link
Contributor

Thank you for your contribution @Michael5601 !

@ruspl-afed
Copy link
Contributor

@Michael5601 I think we need to update target for more recent platform build

[ERROR]   Software being installed: org.eclipse.mylyn.wikitext.ui 4.7.0.qualifier
[ERROR]   Missing requirement: org.eclipse.mylyn.wikitext.ui 4.7.0.qualifier requires 'eclipse.swt; (image.format=svg)' but it could not be found: See log for details

@Michael5601
Copy link
Contributor Author

@Michael5601 I think we need to update target for more recent platform build

[ERROR]   Software being installed: org.eclipse.mylyn.wikitext.ui 4.7.0.qualifier
[ERROR]   Missing requirement: org.eclipse.mylyn.wikitext.ui 4.7.0.qualifier requires 'eclipse.swt; (image.format=svg)' but it could not be found: See log for details

Thanks for the info. How do we do this? Can I even do this?

@ruspl-afed
Copy link
Contributor

Perhaps you can give me an advice re: build where it was merged to Platform.

@Michael5601
Copy link
Contributor Author

Perhaps you can give me an advice re: build where it was merged to Platform.

The feature (and the new fragment org.eclipse.swt.svg) was merged in this PR.

@merks
Copy link
Contributor

merks commented Apr 23, 2025

It's a little strange, only if I explicitly specify org.eclipse.swt.svg in the target platform:

image

does it show up in the content:

image

Otherwise there is only this:

image

That doesn't really make sense to me.

@laeubi @HannesWell

I anticipate that this is going to be a general problem downstream if requiring the feature doesn't automatically pull in the fragment as one would normally expect.

@merks
Copy link
Contributor

merks commented Apr 23, 2025

Hmm, I can't reproduce the problem with a smaller sample target platform which works as expected...

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?>
<target name="New Target">
	<locations>
		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
			<repository location="https://download.eclipse.org/eclipse/updates/4.36-I-builds"/>
			<unit id="org.eclipse.e4.rcp.feature.group"/>
		</location>
	</locations>
</target>

@merks
Copy link
Contributor

merks commented Apr 23, 2025

Oh wait, I didn't notice that the I build is hard coded!

			<repository location="https://download.eclipse.org/eclipse/updates/4.36-I-builds/I20250403-1800/"/>

@ruspl-afed
Copy link
Contributor

ruspl-afed commented Apr 23, 2025

Oh wait, I didn't notice that the I build is hard coded!

Yes, usually it points to Platform milestone build

@merks
Copy link
Contributor

merks commented Apr 23, 2025

Yes, that makes sense, but that's also why this PR can't move forward right now...

@Michael5601 Michael5601 force-pushed the org.eclipse.mylyn.SVGs branch from 499ceee to 288870f Compare May 13, 2025 15:36
…text.ui

This commit adds SVGs for all icons in the bundles `org.eclipse.mylyn.tasks.ui` and `org.eclipse.mylyn.wikitext.ui` except for the following as these are not available as SVG yet:

org.eclipse.mylyn.wikitext.ui/org.eclipse.mylyn.internal.wikitext.ui.util.resources/missing-image.svg
@ruspl-afed ruspl-afed force-pushed the org.eclipse.mylyn.SVGs branch from 288870f to 0409ace Compare May 13, 2025 16:16
@ruspl-afed ruspl-afed merged commit be9796c into eclipse-mylyn:main May 13, 2025
3 checks passed
@Michael5601 Michael5601 deleted the org.eclipse.mylyn.SVGs branch May 27, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants