-
Notifications
You must be signed in to change notification settings - Fork 12
Add SVGs to org.eclipse.mylyn Bundles #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVGs to org.eclipse.mylyn Bundles #707
Conversation
168563d
to
aada70e
Compare
Thank you for your contribution @Michael5601 ! |
bf672fa
to
499ceee
Compare
@Michael5601 I think we need to update target for more recent platform build
|
Thanks for the info. How do we do this? Can I even do this? |
Perhaps you can give me an advice re: build where it was merged to Platform. |
The feature (and the new fragment org.eclipse.swt.svg) was merged in this PR. |
It's a little strange, only if I explicitly specify does it show up in the content: Otherwise there is only this: That doesn't really make sense to me. I anticipate that this is going to be a general problem downstream if requiring the feature doesn't automatically pull in the fragment as one would normally expect. |
Hmm, I can't reproduce the problem with a smaller sample target platform which works as expected...
|
Oh wait, I didn't notice that the I build is hard coded!
|
Yes, usually it points to Platform milestone build |
Yes, that makes sense, but that's also why this PR can't move forward right now... |
499ceee
to
288870f
Compare
…text.ui This commit adds SVGs for all icons in the bundles `org.eclipse.mylyn.tasks.ui` and `org.eclipse.mylyn.wikitext.ui` except for the following as these are not available as SVG yet: org.eclipse.mylyn.wikitext.ui/org.eclipse.mylyn.internal.wikitext.ui.util.resources/missing-image.svg
288870f
to
0409ace
Compare
This PR adds SVGs for all icons in the bundles
org.eclipse.mylyn.tasks.ui
andorg.eclipse.mylyn.wikitext.ui
except for the following as these are not available as SVG yet:org.eclipse.mylyn.wikitext.ui/org.eclipse.mylyn.internal.wikitext.ui.util.resources/missing-image.svg
See also this PR for more information.