Skip to content

Adapt functionality for using SVGs in org.eclipse.mylyn.tasks.ui #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Adapt functionality for using SVGs in org.eclipse.mylyn.tasks.ui #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...yn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/CompareAttachmentsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ protected Object prepareInput(IProgressMonitor pm) throws InvocationTargetExcept
}
}

private static final String[] IMAGE_EXTENSIONS = { ".jpg", ".gif", ".png", ".tiff", ".tif", ".bmp" }; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$
private static final String[] IMAGE_EXTENSIONS = { ".jpg", ".gif", ".png", ".tiff", ".tif", ".bmp", ".svg" }; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$

private Image getImage(ITaskAttachment attachment) {
if (AttachmentUtil.isContext(attachment)) {
Expand Down Expand Up @@ -169,7 +169,7 @@ public String getName() {

@Override
public String getType() {
// ImageMergeViewerCreator - gif,jpg,jpeg,png,bmp,ico,tif,tiff
// ImageMergeViewerCreator - gif,jpg,jpeg,png,bmp,ico,tif,tiff,svg
// BinaryCompareViewerCreator - class,exe,dll,binary,zip,jar
// TextMergeViewerCreator - txt
// PropertiesFileMergeViewerCreator - properties,properties2
Expand Down
2 changes: 1 addition & 1 deletion ...i/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorOutlineNodeLabelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*/
public class TaskEditorOutlineNodeLabelProvider extends LabelProvider {

private static final String[] IMAGE_EXTENSIONS = { "jpg", "gif", "png", "tiff", "tif", "bmp" }; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ @Override
private static final String[] IMAGE_EXTENSIONS = { "jpg", "gif", "png", "tiff", "tif", "bmp", "svg" }; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$ @Override

@Override
public Image getImage(Object element) {
Expand Down
1 change: 1 addition & 0 deletions ...mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/AttachmentPreviewPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ public AttachmentPreviewPage(TaskAttachmentModel model) {
imageTypes.add("image/gif"); //$NON-NLS-1$
imageTypes.add("image/png"); //$NON-NLS-1$
imageTypes.add("image/tiff"); //$NON-NLS-1$
imageTypes.add("image/svg"); //$NON-NLS-1$
}

private void adjustScrollbars(Rectangle imgSize) {
Expand Down