-
Notifications
You must be signed in to change notification settings - Fork 12
Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core #783
Conversation
|
|
||
| private static class NameValue { | ||
|
|
||
| @SuppressWarnings("unused") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps this is needed for persistence or something similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if we really need these fields @gnl42 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is used to build a json string for the Jenkins Form; but I can not find a unit test where parm is filled. So not sure if we can safely delete parts and the private Classes.
5e4ee75 to
c3159f8
Compare
c3159f8 to
5f914d7
Compare
e0b74e5 to
303ce63
Compare
c0aa40b to
8fcfc12
Compare
8fcfc12 to
fa58bc6
Compare
e4db08a to
617c532
Compare
3135845 to
491f500
Compare
491f500 to
4f8e33c
Compare
4f8e33c to
c4275d9
Compare
c4275d9 to
51f1c78
Compare
226e560 to
dd77072
Compare
5056d4a to
0bc2445
Compare
fca2482 to
efe552e
Compare
c100e72 to
d498f1e
Compare
d498f1e to
cde7beb
Compare
The following cleanups were applied: