Clean Code for mylyn.reviews/org.eclipse.mylyn.gerrit.core

[eclipse-mylyn-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

[github-actions]

Test Results

 1 545 files  ±0   1 545 suites  ±0   1h 9m 40s ⏱️ + 6m 59s
 5 006 tests ±0   4 949 ✅ ±0   57 💤 ±0  0 ❌ ±0 
14 450 runs  +2  14 279 ✅ +2  171 💤 ±0  0 ❌ ±0 

Results for commit 67fc5a6. ± Comparison against base commit d2efceb.

♻️ This comment has been updated with latest results.

[BeckerFrank]

We have failing tests for

[BeckerFrank]

We have failing tests

• testFromEmpty (org.eclipse.mylyn.gerrit.tests.core.client.rest.AbandonInputTest)
  expected:<{["message":""]}> but was:<{[]}>
• testFromValid (org.eclipse.mylyn.gerrit.tests.core.client.rest.AbandonInputTest)
  expected:<{["message":"Whatever"]}> but was:<{[]}>
• testFromEmpty (org.eclipse.mylyn.gerrit.tests.core.client.rest.RestoreInputTest)
  expected:<{["message":""]}> but was:<{[]}>
• testFromValid (org.eclipse.mylyn.gerrit.tests.core.client.rest.RestoreInputTest)
  expected:<{["message":"Whatever"]}> but was:<{[]}>

Do you have any idea why JSonSupport().toJson(abandonInput) always returns the JSON structure {[]}?

[BeckerFrank]

I did a test with a mvn clean verify -B -Dmaven.repo.local=/Users/frank/eclipse_prod/.m2/repository -Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true on my Mac M1 environment and the AbandonInputTest and RestoreInputTest did not fail.
The divergence are that I use Java 24 and in the Github Job we have Java 21 on x86_64

Should I deactivate the two failing Test Classes?

[BeckerFrank]

We have failing tests

• testFromEmpty (org.eclipse.mylyn.gerrit.tests.core.client.rest.AbandonInputTest)
  expected:<{["message":""]}> but was:<{[]}>
• testFromValid (org.eclipse.mylyn.gerrit.tests.core.client.rest.AbandonInputTest)
  expected:<{["message":"Whatever"]}> but was:<{[]}>
• testFromEmpty (org.eclipse.mylyn.gerrit.tests.core.client.rest.RestoreInputTest)
  expected:<{["message":""]}> but was:<{[]}>
• testFromValid (org.eclipse.mylyn.gerrit.tests.core.client.rest.RestoreInputTest)
  expected:<{["message":"Whatever"]}> but was:<{[]}>

Do you have any idea why JSonSupport().toJson(abandonInput) always returns the JSON structure {[]}?

The cleanup remove the private field message so there is no data needed to convert to a json String.
Should we generate the getter / setter methods to prevent the cleanup change?