Skip to content

Fixes #165 - Infinite loop in performance grouping header #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fipro78 merged 1 commit into from
Aug 8, 2025
Merged

Fixes #165 - Infinite loop in performance grouping header #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...ore/src/org/eclipse/nebula/widgets/nattable/group/performance/ColumnGroupHeaderLayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,6 +2362,9 @@ public void handleLayerEvent(ILayerEvent event) {
((IStructuralChangeEvent) event).isHorizontalStructureChanged()) {
IStructuralChangeEvent changeEvent = (IStructuralChangeEvent) event;
Collection<StructuralDiff> columnDiffs = changeEvent.getColumnDiffs();

boolean performUpdate = false;

if (columnDiffs != null && !columnDiffs.isEmpty()) {

int[] deletedPositions = getDeletedPositions(columnDiffs);
Expand All @@ -2379,6 +2382,8 @@ public void handleLayerEvent(ILayerEvent event) {
} else {
handleDeleteDiffs(deletedPositions);
}

performUpdate = true;
}

for (StructuralDiff diff : columnDiffs) {
Expand Down Expand Up @@ -2469,11 +2474,15 @@ public void handleLayerEvent(ILayerEvent event) {
doCommand(cmd);
}
}

performUpdate = true;
}
}

// update visible start positions of all groups
updateVisibleStartPositions();
if (performUpdate) {
// update visible start positions of all groups
updateVisibleStartPositions();
}
} else {
// trigger a consistency check as the details of the event
// probably where removed on converting the layer stack
Expand Down
13 changes: 11 additions & 2 deletions ...e.core/src/org/eclipse/nebula/widgets/nattable/group/performance/RowGroupHeaderLayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,6 +2351,9 @@ public void handleLayerEvent(ILayerEvent event) {
((IStructuralChangeEvent) event).isVerticalStructureChanged()) {
IStructuralChangeEvent changeEvent = (IStructuralChangeEvent) event;
Collection<StructuralDiff> rowDiffs = changeEvent.getRowDiffs();

boolean performUpdate = false;

if (rowDiffs != null && !rowDiffs.isEmpty()) {

int[] deletedPositions = getDeletedPositions(rowDiffs);
Expand All @@ -2368,6 +2371,8 @@ public void handleLayerEvent(ILayerEvent event) {
} else {
handleDeleteDiffs(deletedPositions);
}

performUpdate = true;
}

for (StructuralDiff diff : rowDiffs) {
Expand Down Expand Up @@ -2457,12 +2462,16 @@ public void handleLayerEvent(ILayerEvent event) {
for (UpdateRowGroupCollapseCommand cmd : collapseUpdates.values()) {
doCommand(cmd);
}

performUpdate = true;
}
}
}

// update visible start positions of all groups
updateVisibleStartPositions();
if (performUpdate) {
// update visible start positions of all groups
updateVisibleStartPositions();
}
} else {
// trigger a consistency check as the details of the event
// probably where removed on converting the layer stack
Expand Down