Open
Conversation
Open
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
…y project Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
2b819f6 to
709efed
Compare
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
There was a problem hiding this comment.
Pull request overview
This PR enhances the Service Process implementation with improved binary data handling, better connection management, and more robust error handling based on testing with the IntelliJ OCT integration.
Key changes include:
- Refactored message handling to use explicit method-based handlers instead of generic OCP message wrappers
- Added binary data encoding/decoding infrastructure with
BinaryDatatype and conversion utilities - Improved collaboration instance lifecycle with proper cleanup and disposal
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/open-collaboration-service-process/src/messages.ts | Removed generic OCP message types, added BinaryData infrastructure, new notifications (EditorOpenedNotification, PeerJoinedNotification, etc.), and GetDocumentContent request |
| packages/open-collaboration-service-process/src/message-handler.ts | Refactored to use method-based handlers with binary data conversion, added error handling for login/room operations, renamed variables for clarity |
| packages/open-collaboration-service-process/src/collaboration-instance.ts | Integrated normalized Yjs document handling, added document content retrieval, improved selection tracking with normalization, enhanced disposal logic |
| packages/open-collaboration-service-process/test/service.process.test.ts | Updated tests to use new binary data handling and method-based message handlers, added file read test, adjusted timeout |
| packages/open-collaboration-service-process/Readme.md | Added comprehensive documentation for usage, communication protocol, and binary data handling |
| .vscode/launch.json | Added debug configuration for attaching to service process |
| .editorconfig | Added XML file indentation configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/open-collaboration-service-process/src/message-handler.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple improvements to the Service Process based on tests with https://github.com/eclipse-oct/oct-intellij