Skip to content

Service process improvements#137

Open
jonah-iden wants to merge 30 commits intomainfrom
jiden/service-process-improvements
Open

Service process improvements#137
jonah-iden wants to merge 30 commits intomainfrom
jiden/service-process-improvements

Conversation

@jonah-iden
Copy link
Copy Markdown
Contributor

Multiple improvements to the Service Process based on tests with https://github.com/eclipse-oct/oct-intellij

@jonah-iden jonah-iden marked this pull request as draft May 28, 2025 11:17
@jonah-iden jonah-iden mentioned this pull request May 30, 2025
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
…y project

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden force-pushed the jiden/service-process-improvements branch from 2b819f6 to 709efed Compare November 20, 2025 14:12
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from Copilot December 4, 2025 13:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Service Process implementation with improved binary data handling, better connection management, and more robust error handling based on testing with the IntelliJ OCT integration.

Key changes include:

  • Refactored message handling to use explicit method-based handlers instead of generic OCP message wrappers
  • Added binary data encoding/decoding infrastructure with BinaryData type and conversion utilities
  • Improved collaboration instance lifecycle with proper cleanup and disposal

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/open-collaboration-service-process/src/messages.ts Removed generic OCP message types, added BinaryData infrastructure, new notifications (EditorOpenedNotification, PeerJoinedNotification, etc.), and GetDocumentContent request
packages/open-collaboration-service-process/src/message-handler.ts Refactored to use method-based handlers with binary data conversion, added error handling for login/room operations, renamed variables for clarity
packages/open-collaboration-service-process/src/collaboration-instance.ts Integrated normalized Yjs document handling, added document content retrieval, improved selection tracking with normalization, enhanced disposal logic
packages/open-collaboration-service-process/test/service.process.test.ts Updated tests to use new binary data handling and method-based message handlers, added file read test, adjusted timeout
packages/open-collaboration-service-process/Readme.md Added comprehensive documentation for usage, communication protocol, and binary data handling
.vscode/launch.json Added debug configuration for attaching to service process
.editorconfig Added XML file indentation configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden marked this pull request as ready for review December 4, 2025 13:33
@jonah-iden jonah-iden requested a review from msujew December 4, 2025 14:02
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants