Fixed number parsing for --port.

[Windows81]

Normally, utilising oct-server -p 81 will print the message:

Open Collaboration Server listening on localhost:NaN

This pull request attempts to fix that.

Refer to https://www.npmjs.com/package/commander#custom-option-processing for this implementation.

[msujew]

Hey @Windows81, thanks a lot for the contribution!

Before we can accept your changes, please sign the Eclipse Contributor Agreement (ECA) with the same email that was used to create the commit. This is a simple CLA that simply keeps legal trouble out of the way :)

This will also automatically pass the check on your other PR over at #154.

[Windows81]

I took a look at it. However, as this is my first time contributing, I need to make an account with Eclipse.

Problem is that I'm not currently able to get the CAPTCHA to validate properly.

My email address is nastyahmede@gmail.com in case that's needed.

[msujew]

Have you signed the ECA with nastyahmede@gmail.com? Because the commit was created with the aboshadi.n.ahmed@gmail.com email address. Please either sign the ECA with this email or amend your commit to change the email address to the one that was used to sign the ECA.

[Windows81]

Thanks for the clarification. I actually haven't properly signed the commit with either. Hold on.

[msujew]

@Windows81 Did you have a chance to try it again?

[Windows81]

Might try again soon.

[msujew]

@Windows81 Any updates? I'll close the PR (and #154) at the end of the week unless we can fix the ECA issue.

[Windows81]

Hi. Soon after your last reply, I tried to make an account again, but the same problem occurred. I was still unable to make the account.

I'll go ahead and try again soon.

[Windows81]

I signed it. However, because I used the wrong email address, I'll need to get that changed. Thank you for your patience.

[Windows81]

@msujew: I changed my Eclipse account's email address. Eclipse does not allow email addresses to contain dots. However, the address on my commit does have these dots.

Please review.

[msujew]

Eclipse does not allow email addresses to contain dots.

That is news to me? My email associated to my eclipse account does contain a dot. I don't think that's the issue.

However, the address on my commit does have these dots.

Then please amend the email address on your commit to use the same email that was used to sign the ECA. Unless the ECA check passes, we won't be able to merge the PR.

[Windows81]

I made sure that the email addresses for commiter, author, and Eclipse account all match. I'll give the site some time to update.

[msujew]

@Windows81 Thank you, the ECA now works. I'll take a look at the changes in the upcoming days. In the meantime, do you mind fixing the linting and build errors (as seen in the CI)?

[msujew]

There are still linting and build errors in the changes.

[msujew]

Superseded by #167.