modify to throw MqttException if MqttAsyncClient.connect() is called when there is no message broker#1022
Open
angry-2k wants to merge 2 commits intoeclipse-paho:masterfrom
Open
modify to throw MqttException if MqttAsyncClient.connect() is called when there is no message broker#1022angry-2k wants to merge 2 commits intoeclipse-paho:masterfrom
angry-2k wants to merge 2 commits intoeclipse-paho:masterfrom
Conversation
…alled when there is no message broker (message broker service is down due to a failure, or address is incorrect...) For users who use the library, debugging is very difficult unless exceptions are thrown in such cases. Currently, if the message broker attempts to connect to a situation that does not exist, there is a risk of performing the next logic without any exceptions being returned. Of course, the getException() of the IMqttToken instance returned to the connect() call can be checked for an Exception, but it is difficult to use because it is not synchronized. I think it's right to make an exception in this particular case.
…alled when there is no message broker (message broker service is down due to a failure, or address is incorrect...) For users who use the library, debugging is very difficult unless exceptions are thrown in such cases. Currently, if the message broker attempts to connect to a situation that does not exist, there is a risk of performing the next logic without any exceptions being returned. Of course, the getException() of the IMqttToken instance returned to the connect() call can be checked for an Exception, but it is difficult to use because it is not synchronized. I think it's right to make an exception in this particular case.
angry-2k
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix : modify to throw MqttException if MqttAsyncClient.connect() is called when there is no message broker (message broker service is down due to a failure, or address is incorrect...)
For users who use the library, debugging is very difficult unless exceptions are thrown in such cases.
Currently, if the message broker attempts to connect to a situation that does not exist, there is a risk of performing the next logic without any exceptions being returned.
Of course, the getException() of the IMqttToken instance returned to the connect() call can be checked for an Exception, but it is difficult to use because it is not synchronized.
I think it's right to make an exception in this particular case.
issue #1020