Fix crash when third party cookies are disabled #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
stocaaro
approved these changes
Jan 5, 2023
stocaaro
left a comment
stocaaro
left a comment
There was a problem hiding this comment.
What is the process to get this change merged to this package?
stocaaro
added a commit
to stocaaro/amplify-js
that referenced
this pull request
Jan 9, 2023
Original PR: eclipse-paho/paho.mqtt.javascript#247 Co-authored-by: Sam Dawson <[email protected]>
elorzafe
pushed a commit
to aws-amplify/amplify-js
that referenced
this pull request
Jan 12, 2023
Original PR: eclipse-paho/paho.mqtt.javascript#247 Co-authored-by: Sam Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using chrome with third-party cookies disabled accessing local storage causes an error that will crash an app