Skip to content

Commit 25869f8

Browse files
eclipse-pde-botlaeubi
authored andcommitted
Perform clean code of ui/org.eclipse.pde.spy.preferences
1 parent 59fae8d commit 25869f8

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

ui/org.eclipse.pde.spy.preferences/src/org/eclipse/pde/spy/preferences/model/PreferenceEntryPatternFilter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ public PreferenceEntryPatternFilter() {
2525
@Override
2626
protected boolean isLeafMatch(Viewer viewer, Object element) {
2727

28-
if (element instanceof PreferenceEntry) {
29-
PreferenceEntry preferenceEntry = (PreferenceEntry) element;
28+
if (element instanceof PreferenceEntry preferenceEntry) {
3029
if (wordMatches(preferenceEntry.getNodePath()) || wordMatches(preferenceEntry.getKey())
3130
|| wordMatches(preferenceEntry.getOldValue()) || wordMatches(preferenceEntry.getNewValue())) {
3231
return true;

ui/org.eclipse.pde.spy.preferences/src/org/eclipse/pde/spy/preferences/parts/PreferenceSpyPart.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,7 @@ private PreferenceEntry findPreferenceEntry(PreferenceEntry preferenceEntry) {
172172
if (parent instanceof PreferenceNodeEntry) {
173173
IObservableSet<Object> preferenceEntries = ((PreferenceNodeEntry) parent).getPreferenceEntries();
174174
for (Object object : preferenceEntries) {
175-
if (object instanceof PreferenceEntry) {
176-
PreferenceEntry existingPreferenceEntry = (PreferenceEntry) object;
175+
if (object instanceof PreferenceEntry existingPreferenceEntry) {
177176
if (existingPreferenceEntry.getKey().equals(preferenceEntry.getKey())) {
178177
return existingPreferenceEntry;
179178
}

ui/org.eclipse.pde.spy.preferences/src/org/eclipse/pde/spy/preferences/viewer/PreferenceEntryViewerComparator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ public PreferenceEntryViewerComparator(Comparator<? super String> comparator) {
3030

3131
@Override
3232
public int compare(Viewer viewer, Object e1, Object e2) {
33-
if (e1 instanceof PreferenceEntry && e2 instanceof PreferenceEntry) {
34-
PreferenceEntry entry1 = (PreferenceEntry) e1;
33+
if (e1 instanceof PreferenceEntry entry1 && e2 instanceof PreferenceEntry) {
3534
PreferenceEntry entry2 = (PreferenceEntry) e2;
3635

3736
long time = entry1.getTime();

ui/org.eclipse.pde.spy.preferences/src/org/eclipse/pde/spy/preferences/viewer/PreferenceSpyEditingSupport.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ protected boolean canEdit(Object element) {
4444
@Override
4545
protected Object getValue(Object element) {
4646
String value = null;
47-
if (element instanceof PreferenceEntry) {
48-
PreferenceEntry preferenceEntry = (PreferenceEntry) element;
47+
if (element instanceof PreferenceEntry preferenceEntry) {
4948
switch (field) {
5049
case nodePath:
5150
value = preferenceEntry.getNodePath();

0 commit comments

Comments
 (0)