Remove (almost) unused method from provisional IApiBaselineManager#1533
Remove (almost) unused method from provisional IApiBaselineManager#1533laeubi wants to merge 2 commits intoeclipse-pde:masterfrom
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
The IApiBaselineManager contains a helper method IApiBaselineManager#getWorkspaceComponent that is only used in one test. The method has the drawback that one can't distinguish the case if no baseline is set or the component is not found additionally it might later depend on a disposed component. Because of that the method is now removed and the single reference changed accordingly.
9734f76 to
98ea07e
Compare
Test Results 273 files - 12 273 suites - 12 41m 19s ⏱️ - 10m 52s For more details on these failures, see this check. Results for commit 98ea07e. ± Comparison against base commit 0b123e0. This pull request skips 1 test. |
The
IApiBaselineManagercontains a helper methodIApiBaselineManager#getWorkspaceComponentthat is only used in one test. The method has the drawback that one can't distinguish the case if no baseline is set or the component is not found additionally it might later depend on a disposed component.Because of that the method is now removed and the single reference changed accordingly.