Persist the sequence number if it changes to the document#1542
Closed
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Closed
Persist the sequence number if it changes to the document#1542laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
Currently the targetdefinition is maintaining a sequence number that should roughly reflect the number of times a relevant property of the target file changes. Currently this number is never written out to the XML making it only effective at runtime but not e.g. when committed to a VCS if not maintained manually. This now makes sure that the number is correctly persisted in the XML.
laeubi
force-pushed
the
fix_seq_number
branch
from
a313e0c to
5dbc553
Compare
Member
|
Isn't this the opposite direction as started with your other PRs?
Therefore I'm not sure we should continue here. |
Contributor
Author
|
Unless it is not removed, it should at least work... but it looks like making it work / persisted already breaks a lot of stuff, so it serves as another proof that maybe removing it completely is a better choice. |
Contributor
Author
|
This one would be obsolete if we merge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the targetdefinition is maintaining a sequence number that should roughly reflect the number of times a relevant property of the target file changes. Currently this number is never written out to the XML making it only effective at runtime but not e.g. when committed to a VCS if not maintained manually.
This now makes sure that the number is correctly persisted in the XML.