Remove dependency to icu4j for html exports#1574
Conversation
|
@waynebeaton I'm not really sure about the "IP" here, is a list of strings already something we need a vetting from the IP team? The source where I found the list mentions New BSD License Theoretical I could extract the code into an on class and license it under that as well... I'm just not sure if this is a bit exaggerated here... |
|
It would maybe better to move the code to https://github.com/eclipse-equinox/equinox/tree/master/bundles/org.eclipse.equinox.bidi so it can be reused. |
|
Sorry for the delay. My recommendation is that you indicate to the source of the content in a comment. Further investigation isn't a good use of anybody's time. |
The only reason for icu4j currently is to determine if a RTL language is used as the default locale on html exports. This replaces the fat (12MB!) dependency by a simpler variant that seems suitable for the sake of generating html reports.
|
@waynebeaton I added the link now to the source, thanks for the response here, so API tools is no free of ICU4j and I'll merge as soon as build passes. This is also important for Tycho that uses PDE at some places so one less heavy dependency here as well! |
|
This is great! Thanks. |
3 participants
The only reason for icu4j currently is to determine if a RTL language is used as the default locale on html exports.
This replaces the fat (12MB!) dependency by a simpler variant that seems suitable for the sake of generating html reports.
The list of codes is taken from https://raw.githubusercontent.com/shadiabuhilal/rtl-detect/2eed8a33276461a24e7033d1d3a115ee64aee3f5/lib/rtl-detect.js and adapted to java.