fix ClasspathComputer: ignore if oldEntry not found #820#1601
Merged
jukzi merged 1 commit intoeclipse-pde:masterfrom Feb 6, 2025
Merged
fix ClasspathComputer: ignore if oldEntry not found #820#1601jukzi merged 1 commit intoeclipse-pde:masterfrom
jukzi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Contributor
Author
|
how about that? @haubi @laeubi @iloveeclipse @HannesWell ? |
iloveeclipse
reviewed
Feb 5, 2025
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/ClasspathComputer.java
Outdated
Show resolved
Hide resolved
jukzi
force-pushed
the
fix_ClasspathComputer
branch
from
99719ec to
cf528da
Compare
laeubi
reviewed
Feb 6, 2025
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/ClasspathComputer.java
Outdated
Show resolved
Hide resolved
fixes random failing ClasspathUpdaterTest When IJavaProject.setRawClasspath() is explicitly called with ClasspathEntries distinct from PDE (like in the Test), and then later PDEs UpdateClasspathJob is executed it can't compute the "oldEntry" and fails with "... is not on its projects build path". The Message is correct - it was manually removed from the projects build path. That state should just be ignored so that PDE continues to set the IClasspathEntries computed by PDE. eclipse-pde#820
jukzi
force-pushed
the
fix_ClasspathComputer
branch
from
cf528da to
a03dbf6
Compare
laeubi
approved these changes
Feb 6, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
This looks like something we can do to be more defensive in error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes random failing ClasspathUpdaterTest
When IJavaProject.setRawClasspath() is explicitly called with ClasspathEntries distinct from PDE (like in the Test), and then later PDEs UpdateClasspathJob is executed it can't compute the "oldEntry" and fails with "... is not on its projects build path". The Message is correct - it was manually removed from the projects build path. That state should just be ignored so that PDE continues to set the IClasspathEntries computed by PDE.
#820