Skip to content

Updating marker to disable Quick Fix option if 'Configure problem severity' is the only available options#1615

Merged
gireeshpunathil merged 1 commit intoeclipse-pde:masterfrom
nburnwal09:QuickFix_4135
May 27, 2025
Merged

Updating marker to disable Quick Fix option if 'Configure problem severity' is the only available options#1615
gireeshpunathil merged 1 commit intoeclipse-pde:masterfrom
nburnwal09:QuickFix_4135

Conversation

@nburnwal09
Copy link

This commit fixes the Quick fix option when 'Configure problem severity' is the only available options for the selected problem in the problems tab.

It in turns greys out the Quick fix option when there is no fix attached to the respective problem. This will into misleads developers into thinking that a quick fix is available for the problem when there is no available fix
Previously, it was showing a pop-up saying 'No quick fixes available.'
Attaching the screenshot of the fix
image

Fixes: #1614

@laeubi
Copy link
Contributor

laeubi commented Feb 13, 2025

Will it still work to configure the severity of the problem in Manifest editor?

@nburnwal09
Copy link
Author

Yes, that part will work fine.

@github-actions
Copy link

github-actions bot commented Feb 13, 2025

Test Results

   285 files  ±0     285 suites  ±0   58m 49s ⏱️ + 2m 46s
 3 611 tests ±0   3 535 ✅ ±0   76 💤 ±0  0 ❌ ±0 
11 025 runs  ±0  10 794 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit f65090d. ± Comparison against base commit 85e7255.

♻️ This comment has been updated with latest results.

@nburnwal09
Copy link
Author

nburnwal09 commented Apr 24, 2025

@laeubi I have verified the "working of configure the severity of the problem."
@HannesWell kindly review this PR.

@nburnwal09
Copy link
Author

nburnwal09 commented May 12, 2025

@laeubi
Could you please review this PR when you have some time.

@gireeshpunathil gireeshpunathil merged commit bc2f62c into eclipse-pde:master May 27, 2025
19 checks passed
@akurtakov
Copy link
Member

@gireeshpunathil Why do you merge things for RC2 without required approvals? @HannesWell I leave it to you as PL to decide what to do here.

@gireeshpunathil
Copy link
Contributor

oops.. missed the fact on the rc2. should this be reverted?

@merks
Copy link
Contributor

merks commented May 27, 2025

It looks innocent enough...

@HannesWell
Copy link
Member

@gireeshpunathil Why do you merge things for RC2 without required approvals? @HannesWell I leave it to you as PL to decide what to do here.

I looked into it and all the callers and also think this change is save enough to keep it.
However we should really not do that more often, but I think we don't have to discuss that.

I'll also check if it's possible to run the freeze-time check again as long as the PR is open to get a red-marker even if the PR has was not changed in the meantime.

@HannesWell
Copy link
Member

But besides the bad timing of the merge, thank you @nburnwal09 for your contribution. That's a nice enhancement to make the UI better and sorry that it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppress resolution if 'Configure problem severity' is the only available options

6 participants