Skip to content

Move bnd autocompletion to shared components / Fix some issues with bnd instruction autocompleter#1636

Merged
laeubi merged 3 commits intoeclipse-pde:masterfrom
laeubi:move_and_fix
Mar 5, 2025
Merged

Move bnd autocompletion to shared components / Fix some issues with bnd instruction autocompleter#1636
laeubi merged 3 commits intoeclipse-pde:masterfrom
laeubi:move_and_fix

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Mar 4, 2025

Fix some issues with bnd instruction autocompleter:

  • If line is comment, don't propose any autocompletion
  • Do not autocomplete if line already contains an instruction
  • Do not provide auto-completion for continuation lines

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Test Results

   285 files  ±0     285 suites  ±0   47m 35s ⏱️ - 3m 37s
 3 608 tests ±0   3 532 ✅ ±0   76 💤 ±0  0 ❌ ±0 
11 016 runs  ±0  10 785 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit f9d8bd4. ± Comparison against base commit f941e23.

♻️ This comment has been updated with latest results.

laeubi added 2 commits March 5, 2025 10:44
- If line is comment, don't propose any autocompletion
- Do not autocomplete if line already contains an instruction
- Do not provide auto-completion for continuation lines
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b1055b9083160b4a110c4dadd5f4c8ecdf85bb28 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 5 Mar 2025 09:47:21 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
index 6658ef7e4c..c8e5c83a01 100644
--- a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: Generic UI components related to BND
 Bundle-SymbolicName: org.eclipse.pde.bnd.ui;singleton:=true
 Bundle-Vendor: Eclipse.org
-Bundle-Version: 1.2.0.qualifier
+Bundle-Version: 1.2.100.qualifier
 Export-Package: org.eclipse.pde.bnd.ui.autocomplete;version="1.0.0";x-friends:="org.eclipse.pde.ui",
  org.eclipse.pde.bnd.ui.plugins;x-internal:=true,
  org.eclipse.pde.bnd.ui.preferences;version="1.0.0";x-friends:="org.eclipse.pde.ui",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@laeubi laeubi merged commit 1eaf8ac into eclipse-pde:master Mar 5, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants