Skip to content

Clean Code for ui/org.eclipse.pde.spy.css#1681

Merged
laeubi merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.spy.css
Mar 17, 2025
Merged

Clean Code for ui/org.eclipse.pde.spy.css#1681
laeubi merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.spy.css

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-pde-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.spy.css/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 72542c720ea1b876452d462e76f2f57dce1c9821 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Mon, 17 Mar 2025 03:26:17 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.spy.css/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.spy.css/META-INF/MANIFEST.MF
index 978889e64f..a9b9a10981 100644
--- a/ui/org.eclipse.pde.spy.css/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.spy.css/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.spy.css;singleton:=true
-Bundle-Version: 0.13.500.qualifier
+Bundle-Version: 0.13.600.qualifier
 Automatic-Module-Name: org.eclipse.pde.spy.css
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.core.runtime;bundle-version="3.29.0",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

Test Results

  281 files   -     4    281 suites   - 4   45m 1s ⏱️ - 1m 14s
3 608 tests ±    0  3 531 ✅  -     1   76 💤 ± 0  0 ❌ ±0  1 🔥 +1 
8 324 runs   - 2 692  8 116 ✅  - 2 669  207 💤  - 24  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 5598505. ± Comparison against base commit 338779a.

@laeubi laeubi merged commit 874e43f into master Mar 17, 2025
16 of 18 checks passed
@laeubi laeubi deleted the clean-code/ui/org.eclipse.pde.spy.css branch March 17, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants