Skip to content

Clean Code for ui/org.eclipse.ui.trace#1686

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.ui.trace
Mar 19, 2025
Merged

Clean Code for ui/org.eclipse.ui.trace#1686
akurtakov merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.ui.trace

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 17, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.ui.trace/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 11c4efe6c41e024f4e18e1fc8a7655631382c72c Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 19 Mar 2025 03:40:03 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.ui.trace/META-INF/MANIFEST.MF b/ui/org.eclipse.ui.trace/META-INF/MANIFEST.MF
index 712653fb88..3f9e332ff7 100644
--- a/ui/org.eclipse.ui.trace/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.ui.trace/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.trace;singleton:=true
-Bundle-Version: 1.3.400.qualifier
+Bundle-Version: 1.3.500.qualifier
 Bundle-Activator: org.eclipse.ui.trace.internal.TracingUIActivator
 Bundle-Vendor: %providerName
 Bundle-RequiredExecutionEnvironment: JavaSE-17
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Mar 17, 2025

Test Results

   285 files  +  6     285 suites  +6   47m 54s ⏱️ + 4m 14s
 3 608 tests ±  0   3 532 ✅ +  1   76 💤 ± 0  0 ❌  - 1 
11 016 runs  +194  10 785 ✅ +165  231 💤 +30  0 ❌  - 1 

Results for commit aa7e851. ± Comparison against base commit 83a3ef3.

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.ui.trace branch from 53fadba to c5b2253 Compare March 18, 2025 03:30
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.ui.trace branch from db3a91c to 873f5a4 Compare March 19, 2025 03:32
@akurtakov akurtakov merged commit 5b1d6bf into master Mar 19, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/ui/org.eclipse.ui.trace branch March 19, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants