Skip to content

Clean Code for ui/org.eclipse.pde.spy.css#1704

Merged
laeubi merged 1 commit intomasterfrom
clean-code/ui/org.eclipse.pde.spy.css
Mar 25, 2025
Merged

Clean Code for ui/org.eclipse.pde.spy.css#1704
laeubi merged 1 commit intomasterfrom
clean-code/ui/org.eclipse.pde.spy.css

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions
Copy link

github-actions bot commented Mar 22, 2025

Test Results

   273 files   -     8     273 suites   - 8   43m 2s ⏱️ -1s
 3 608 tests ±    0   3 530 ✅  -     1   77 💤 + 1  1 ❌ ±0 
10 628 runs  +2 304  10 453 ✅ +2 337  173 💤  - 34  2 ❌ +1 

For more details on these failures, see this check.

Results for commit bc33a12. ± Comparison against base commit 5d4fd66.

This pull request skips 1 test.
org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.spy.css branch from 57a34b9 to bc33a12 Compare March 23, 2025 03:23
@laeubi laeubi merged commit 2a44679 into master Mar 25, 2025
15 of 18 checks passed
@akurtakov akurtakov deleted the clean-code/ui/org.eclipse.pde.spy.css branch March 25, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants