OSGi Repoviewer: sync features with bndtools#1758
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom May 6, 2025
Merged
Conversation
laeubi
reviewed
May 6, 2025
ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/RepositoryUtils.java
Show resolved
Hide resolved
laeubi
reviewed
May 6, 2025
chrisrueger
force-pushed
the
repoviewer-sync-features-with-bndtools
branch
2 times, most recently
from
7d9177a to
13b94b7
Compare
Contributor
Author
|
I am just fighting with JGit cleaning up and creating other PRs. Hold on for a few minutes. |
chrisrueger
force-pushed
the
repoviewer-sync-features-with-bndtools
branch
3 times, most recently
from
0f25e75 to
74eba17
Compare
chrisrueger
force-pushed
the
repoviewer-sync-features-with-bndtools
branch
3 times, most recently
from
b9cec36 to
258769c
Compare
Contributor
Author
|
@laeubi I think this one is ready. Icon is also fixed |
Contributor
|
@chrisrueger can you look at the compiler warnings? https://github.com/eclipse-pde/eclipse.pde/pull/1758/checks?check_run_id=41716536640 |
- add features added in bndtools RepositoriesView since pde migration Repo View: Show workspace-repo if bnd workspace - if there is a cnf project (which is the marker for a bnd workspace) then we now show the WorkspaceRepository which contains all projects better detect BND workspace add icon for workspacerepo fix compiler warnings
chrisrueger
force-pushed
the
repoviewer-sync-features-with-bndtools
branch
from
258769c to
7e84701
Compare
Contributor
Author
It was 3 unused imports. Sorry for that. I am so used to Save-actions -> Organize Import, that I didn't check that. But it was disabled in this new Eclipse instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.