Bndtools-to-PDE: Migrate Resolutionview to PDE #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
May 7, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
Thanks for working on this, what currently is missing:
- License headers, these must be restored from git history of bnd
- the view must be made available in
plugin.xmlso it can actually be shown
Beside that it would be good to have one commit that contains the original files from BND (with just the header added) and one follow up that adds your changes /adjustment (e.g. package name changes, formatting, cleanup and so on), so it is easier to create a CQ for this.
ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/internal/SelectionUtils.java
Outdated
Show resolved
Hide resolved
ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/internal/SelectionUtils.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
May 7, 2025
ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/tasks/AnalyseBundleResolutionJob.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
May 7, 2025
ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/tasks/AnalyseBundleResolutionJob.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
May 7, 2025
ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/tasks/AnalyseBundleResolutionJob.java
Show resolved
Hide resolved
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
from
4a169df to
1420d6e
Compare
chrisrueger
added a commit
to chrisrueger/eclipse.platform.releng.aggregator
that referenced
this pull request
May 7, 2025
- required for PR eclipse-pde/eclipse.pde#1763
Contributor
Author
|
Waiting for eclipse-platform/eclipse.platform.releng.aggregator#3030 for required util library- Until this is available build will fail. |
Contributor
Author
Done in 1st commit f40532e
Already the case. |
laeubi
pushed a commit
to eclipse-platform/eclipse.platform.releng.aggregator
that referenced
this pull request
May 7, 2025
- required for PR eclipse-pde/eclipse.pde#1763
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
from
4096368 to
f5d3388
Compare
laeubi
force-pushed
the
bnd-resolutionview-to-pde
branch
from
f5d3388 to
e4b3ab7
Compare
Contributor
|
@chrisrueger I created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21016 now to import the content from bndtools repo into PDE. |
chrisrueger
changed the title
Contributor
Author
|
I think I found the reason
the 
and Booom a ClassCastException is thrown. I will investigate and work out a fix. |
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
from
e4b3ab7 to
b277fab
Compare
Contributor
Author
|
Fixed the ClassCastException in b277fab When I click on the repo "PDE Target Platform State" I get this: It does not happen when I click on single entries. |
Contributor
Author
|
Now a new exception when I click on the "PDE Target Platform State" and have the Resolution View open: |
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
from
b277fab to
7f5b317
Compare
Contributor
Author
|
@laeubi I think this is in an OK state for the first version. Regarding the last exception ( I don't know what I can do here. Maybe it is just my setup. You remember my Eclipse SDK has still some read problems but I can launch the Runtime Workspace, but there are some errors still. If you think this is ok too, then I do a final squash of commits. |
Contributor
Yes but please keep the first one intact where you imported the files from bnd tools! |
Contributor
|
While we are waiting for CQ approval, you probably want to prepare a N&N entry here: https://github.com/eclipse-platform/www.eclipse.org-eclipse/blob/master/news/4.36/pde.md after this is merged we can find it here: https://eclipse.dev/eclipse/markdown/?f=news/4.36/pde.md And should add a note here: https://github.com/eclipse-pde/eclipse.pde/blob/master/ui/org.eclipse.pde.bnd.ui/README.MD#available-components |
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
2 times, most recently
from
3aff451 to
7ed950b
Compare
- This commit does not compile - it only serves the purpose of having all migrated files in one place + the license headers - later commits will put those files in different folders, do cleanup etc.
HannesWell
reviewed
May 8, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Hi @chrisrueger
thanks for this contribution. This looks promising and at the moment PDE indeed lacks the capability to analyze resolution problems easily. I hope this can close this gap.
I didn't had the time yet to look into the details, but just from looking over this briefly, I was wondering if the icons are also available as SVG images?
We have recently added SVG support in SWT and a lot of icons where migrated to use their SVG version.
It would be great if new icons are added as SVG directly.
Contributor
Author
I just copied them over from bndtools as they were there for decades :)
I will try if I can do that somehow. |
Member
That's not a surprise. :D
That would be great, thanks. On the other hand, it's not a blocker if that's too much work. Just one day they should be SVGs and ideally from day one. |
Contributor
Author
Quick question regarding active / inactive state? I read somewhere that Eclipse can do this automatically quite well (don't remember where I read that). So should I just convert and use the active state images and Eclipse will do the inactive somewhow? Example: 
Should I convert both or is the green one enough and the greyed out can be done automatically? |
Contributor
|
@HeikoKlare can you advice regarding the active/inactive ones? |
Contributor
Might be that you are referring to this recent news: https://eclipse.dev/eclipse/markdown/?f=news/4.36/platform.md#improved-disabled-icons-generation-
I would not provide pre-generated disabled/inactive icons anymore. The algorithm for calculating them out of the original icon has been improved (see the news above) such that results are (almost) equal to how the pre-generated disabled icons in Eclipse looked before. For the disabled icon of A further benefit of using the automatic algorithm in SWT is that you can exchange the used algorithm (also see the news above), so that a different look will consistently be applied to also your disabled/inactive images if (and only if) they are generated with that algorithm. |
Contributor
Author
|
Question regarding the icons: Bndtools has used some icons from https://icons8.com/license The icons are free if there is a link to icons8. How do we do this now in Eclipse? If there is a way, I would also check for SVG replacements for the current icons. Or where do you guys get icons from? |
Contributor
|
@chrisrueger we have https://github.com/eclipse-platform/eclipse.platform.images/ for Eclipse images, if you can use or derive icons from there it would be the best. |
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
from
7ed950b to
7e91689
Compare
Contributor
Author
|
@HannesWell @laeubi @HeikoKlare I replaced as many icons with svgs as I could from https://github.com/eclipse-platform/eclipse.platform.images/ 7e91689 For some I did not find good replacements and left them .png. I suggest I adress the rest in another PR. |
- 1st draft of Bndtools Resolution view, which shows Requirements and Capabilities of selected resources (.jar files, .bnd files, RepositoryView entries) add some missing icons fix more icons Add license headers to migrated files Replace SelectionUtils with Adapters.adapt() cleanup, add suggestions from PR fix icon fix compile warnings fix ClassCastException in CapReqComparator - reason was that the namespace 'osgi.ee' can contain List<Version> - so we now handle cases of single Version vs. List<Version> - for lists we take the highest version for comparison remove temp. migration package svg images - update as many images to svg (taken from https://github.com/eclipse-platform/eclipse.platform.images/tree/master/org.eclipse.images/eclipse-svg) - for some I coudn't find replacements yet. Will do them in another PR
chrisrueger
force-pushed
the
bnd-resolutionview-to-pde
branch
from
7e91689 to
f166aaa
Compare
laeubi
approved these changes
May 13, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
CQ is approved now. When build succeeds I'll merge this any improvement can then be made with follow up PRs.
Contributor
|
@chrisrueger thanks for this useful addition, please add a note for this new feature here: https://github.com/eclipse-platform/www.eclipse.org-eclipse/blob/master/news/4.36/pde.md |
Contributor
Author
|
@laeubi first draft of New and Noteworthy eclipse-platform/www.eclipse.org-eclipse#342 |
Member
Thank you for the updates. Subsequent enhancements are always possible. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the bndtools Resolution View (https://bndtools.org/manual/resolution-view.html) to PDE.
Still work in progress. Just created the Draft PR for discussion of first results.
This is the first screenshot of the Resolution view.
You can click on on any
Open issues