Skip to content

Conversation

@elsazac
Copy link
Contributor

@elsazac elsazac commented Aug 26, 2025

Fixes: #3243



Refs : See eclipse-platform/eclipse.platform.releng.aggregator#3232 (comment)

The New and Noteworthy for Eclipse 4.37 in PDE still points to 4.30 and needs to be updated to 4.37. It hasn’t been revised since the migration of PDE from Platform Common


This is the remaining work of eclipse-platform/eclipse.platform.releng.aggregator#3244

@MohananRahul
@merks

<h2>Plug-in Development Environment</h2>
<p>
The new and noteworthy updates for Eclipse 4.37 can be found
<a href="https://eclipse.dev/eclipse/news/4.37/pde.html" target="_blank">here</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should embedd the content here with an iframe as well?

Also maybe it would be good to use maven filtered resources to automatically have this up to date always, e.g. the "copyright year" is also out of date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment would need to be more broadly applied to the other cases. Let's focus on doing the minimum at this point.

@merks
Copy link
Contributor

merks commented Aug 26, 2025

This subitem would be good to remove too:

image

@elsazac
Copy link
Contributor Author

elsazac commented Aug 26, 2025

This subitem would be good to remove too:

Done.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Now it is consistent with the style and behavior of the other similar entries:

image

@merks
Copy link
Contributor

merks commented Aug 26, 2025

Oh, I saw this in the console just now:

!ENTRY org.eclipse.help 4 0 2025-08-26 09:19:19.901
!MESSAGE Error reading help table of contents file /"org.eclipse.pde.doc.user/topics_WhatsNew.xml, URL = file:/D:/Users/merks/platform-sdk-4.37/ws/.metadata/.plugins/org.eclipse.pde.core/.install_folders/1756109739680/../../../../../../git/eclipse.pde/org.eclipse.pde.doc.user/topics_WhatsNew.xml at line 18, column 1" (skipping file)
!STACK 0
org.xml.sax.SAXParseException; lineNumber: 18; columnNumber: 1; Premature end of file.
	at java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
	at org.eclipse.help.internal.entityresolver.LocalEntityResolver.parse(LocalEntityResolver.java:88)
	at org.eclipse.help.internal.dynamic.DocumentReader.read(DocumentReader.java:56)
	at org.eclipse.help.internal.dynamic.DocumentReader.read(DocumentReader.java:44)
	at org.eclipse.help.internal.toc.TocFileParser.parse(TocFileParser.java:36)
	at org.eclipse.help.internal.toc.TocFileProvider.getTocContributions(TocFileProvider.java:50)
	at org.eclipse.help.internal.toc.TocManager.getAndCacheTocContributions(TocManager.java:214)
	at org.eclipse.help.internal.toc.TocManager.getTocContributionsForToc(TocManager.java:202)
	at org.eclipse.help.internal.toc.TocManager.getRootTocContributions(TocManager.java:311)
	at org.eclipse.help.internal.toc.TocManager.getTocs(TocManager.java:72)
	at org.eclipse.help.internal.toc.TocManager.getTopic(TocManager.java:127)
	at org.eclipse.help.internal.toc.TocManager.getTopicPath(TocManager.java:142)
	at org.eclipse.help.internal.webapp.data.UrlUtil.getTopicPath(UrlUtil.java:243)
	at org.eclipse.help.internal.webapp.servlet.BreadcrumbsFilter.filter(BreadcrumbsFilter.java:78)
	at org.eclipse.help.internal.webapp.servlet.EclipseConnector.transfer(EclipseConnector.java:205)
	at org.eclipse.help.internal.webapp.servlet.ContentServlet.doGet(ContentServlet.java:57)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:503)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:590)
	at org.eclipse.equinox.http.servlet.internal.registration.EndpointRegistration.service(EndpointRegistration.java:154)
	at org.eclipse.equinox.http.servlet.internal.servlet.ResponseStateHandler.processRequest(ResponseStateHandler.java:66)
	at org.eclipse.equinox.http.servlet.internal.context.DispatchTargets.doDispatch(DispatchTargets.java:112)
	at org.eclipse.equinox.http.servlet.internal.servlet.ProxyServlet.dispatch(ProxyServlet.java:144)
	at org.eclipse.equinox.http.servlet.internal.servlet.ProxyServlet.preprocess(ProxyServlet.java:116)
	at org.eclipse.equinox.http.servlet.internal.servlet.ProxyServlet.service(ProxyServlet.java:106)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:590)
	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:349)
	at org.eclipse.jetty.ee8.servlet.ServletHolder.handle(ServletHolder.java:652)
	at org.eclipse.jetty.ee8.servlet.ServletHandler.doHandle(ServletHandler.java:456)
	at org.eclipse.jetty.ee8.nested.ScopedHandler.nextHandle(ScopedHandler.java:179)
	at org.eclipse.jetty.ee8.nested.SessionHandler.doHandle(SessionHandler.java:519)
	at org.eclipse.jetty.ee8.nested.ScopedHandler.nextHandle(ScopedHandler.java:179)
	at org.eclipse.jetty.ee8.nested.ContextHandler.doHandle(ContextHandler.java:881)
	at org.eclipse.jetty.ee8.nested.ScopedHandler.nextScope(ScopedHandler.java:150)
	at org.eclipse.jetty.ee8.servlet.ServletHandler.doScope(ServletHandler.java:423)
	at org.eclipse.jetty.ee8.nested.ScopedHandler.nextScope(ScopedHandler.java:148)
	at org.eclipse.jetty.ee8.nested.SessionHandler.doScope(SessionHandler.java:503)
	at org.eclipse.jetty.ee8.nested.ScopedHandler.nextScope(ScopedHandler.java:148)
	at org.eclipse.jetty.ee8.nested.ContextHandler.doScope(ContextHandler.java:826)
	at org.eclipse.jetty.ee8.nested.ScopedHandler.handle(ScopedHandler.java:115)
	at org.eclipse.jetty.ee8.nested.ContextHandler.handle(ContextHandler.java:1447)
	at org.eclipse.jetty.ee8.nested.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1304)
	at org.eclipse.jetty.ee8.nested.HttpChannel.dispatch(HttpChannel.java:626)
	at org.eclipse.jetty.ee8.nested.HttpChannel.handle(HttpChannel.java:468)
	at org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler$CoreToNestedHandler.handle(ContextHandler.java:2529)
	at org.eclipse.jetty.server.handler.ContextHandler.handle(ContextHandler.java:1174)
	at org.eclipse.jetty.server.Server.handle(Server.java:182)
	at org.eclipse.jetty.server.internal.HttpChannelState$HandlerInvoker.run(HttpChannelState.java:682)
	at org.eclipse.jetty.server.internal.HttpConnection.onFillable(HttpConnection.java:411)
	at org.eclipse.jetty.server.internal.HttpConnection$FillableCallback.succeeded(HttpConnection.java:1819)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:99)
	at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:54)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:999)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1229)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1184)
	at java.base/java.lang.Thread.run(Thread.java:1583)

@elsazac

Could you please test this from a debug launch and track this down?

@github-actions
Copy link

github-actions bot commented Aug 26, 2025

Test Results

   765 files  ±0     765 suites  ±0   53m 18s ⏱️ + 1m 15s
 3 611 tests  - 1   3 556 ✅  - 1   54 💤 ±0  1 ❌ +1 
10 833 runs   - 1  10 669 ✅  - 1  163 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit bf7ced8. ± Comparison against base commit ebb6634.

This pull request removes 1 test.
[22: Menu contribution using 4.x API] ‑ Unknown test

♻️ This comment has been updated with latest results.

@elsazac
Copy link
Contributor Author

elsazac commented Aug 26, 2025

Could you please test this from a debug launch and track this down?

it should be working now.

@merks
Copy link
Contributor

merks commented Aug 26, 2025

I'm out of office. Please someone else fetch the PR and double check.

@subyssurendran666
Copy link

Oh, I saw this in the console just now:

!ENTRY org.eclipse.help 4 0 2025-08-26 09:19:19.901
!MESSAGE Error reading help table of contents file /"org.eclipse.pde.doc.user/topics_WhatsNew.xml, URL = file:/D:/Users/merks/platform-sdk-4.37/ws/.metadata/.plugins/org.eclipse.pde.core/.install_folders/1756109739680/../../../../../../git/eclipse.pde/org.eclipse.pde.doc.user/topics_WhatsNew.xml at line 18, column 1" (skipping file)
!STACK 0
org.xml.sax.SAXParseException; lineNumber: 18; columnNumber: 1; Premature end of file.
	at java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
	at org.eclipse.help.internal.entityresolver.LocalEntityResolver.parse(LocalEntityResolver.java:88)
	at org.eclipse.help.internal.dynamic.DocumentReader.read(DocumentReader.java:56)
	at org.eclipse.help.internal.dynamic.DocumentReader.read(DocumentReader.java:44)

I tried this locally but was unable to see the exception in the console.

@merks
Copy link
Contributor

merks commented Aug 26, 2025

Failing tests unrelated. Will merge doc-only changes.

@merks merks merged commit 379558b into eclipse-pde:master Aug 26, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New and Noteworthy

5 participants