Skip to content

Add SVG to org.eclipse.pde.spy.preferences#1952

Merged
vogella merged 2 commits intoeclipse-pde:masterfrom
BeckerWdf:pde_icons
Dec 8, 2025
Merged

Add SVG to org.eclipse.pde.spy.preferences#1952
vogella merged 2 commits intoeclipse-pde:masterfrom
BeckerWdf:pde_icons

Conversation

@BeckerWdf
Copy link
Contributor

Use SVGs instead of PNGs as platform now supports this.

All SVG already existing and were simply copied over.

For the preference_spy.png an SVG still needs to be created. This will be done in a separate commit.

Contributes to: #1927

@BeckerWdf
Copy link
Contributor Author

The expand / collape all, delete / delete all where greyed out in the current state (PNGs). This looked like these actions are disabled. See:
Screenshot 2025-09-03 at 08 22 49

I think they should be colorful like the other versions of these in platform. So I changed this.
See:
image
image

@HannesWell: Can you pls. review and and manually test?

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Sep 3, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

features/org.eclipse.pde.spies-feature/feature.xml
ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f7d45bf421f53e6b07325bee61227674722e61af Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 3 Dec 2025 14:29:07 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/features/org.eclipse.pde.spies-feature/feature.xml b/features/org.eclipse.pde.spies-feature/feature.xml
index 281945dff8..568926f990 100644
--- a/features/org.eclipse.pde.spies-feature/feature.xml
+++ b/features/org.eclipse.pde.spies-feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.pde.spies"
       label="%featureName"
-      version="1.0.900.qualifier"
+      version="1.0.1000.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF
index 3e2b3e3a75..bd6d4d770c 100644
--- a/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.spy.preferences;singleton:=true
-Bundle-Version: 0.13.700.qualifier
+Bundle-Version: 0.13.800.qualifier
 Automatic-Module-Name: org.eclipse.pde.spy.preferences
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Bundle-Vendor: %provider-name
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Test Results

   771 files  ±0     771 suites  ±0   59m 13s ⏱️ +13s
 3 648 tests ±0   3 594 ✅ +3   54 💤 ±0  0 ❌  - 3 
10 878 runs  ±0  10 715 ✅ +3  163 💤 ±0  0 ❌  - 3 

Results for commit 01d4b87. ± Comparison against base commit 2ecbcf2.

♻️ This comment has been updated with latest results.

Use SVGs instead of PNGs as platform now supports this.

All SVG already existing and were simply copied over.

For the preference_spy.png an SVG still needs to be created.
This will be done in a separate commit.

Contributes to: eclipse-pde#1927
@vogella vogella merged commit 3741a0b into eclipse-pde:master Dec 8, 2025
19 checks passed
@vogella
Copy link
Contributor

vogella commented Dec 8, 2025

Thanks @BeckerWdf

@vogella
Copy link
Contributor

vogella commented Dec 8, 2025

(I still think the blue gradient collapse and expandall should be reworked, the gradient is IMHO win95 style)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants