Skip to content

Delete Unused Icons#1954

Merged
vogella merged 2 commits intoeclipse-pde:masterfrom
BeckerWdf:bnd_ui_unused
Oct 8, 2025
Merged

Delete Unused Icons#1954
vogella merged 2 commits intoeclipse-pde:masterfrom
BeckerWdf:bnd_ui_unused

Conversation

@BeckerWdf
Copy link
Contributor

Contributes to: #1927

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2e573082cffb22f78abe3c099ac01150883e8e90 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 3 Sep 2025 12:19:39 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
index 6e1de55ab6..00ad9d5c91 100644
--- a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: Generic UI components related to BND
 Bundle-SymbolicName: org.eclipse.pde.bnd.ui;singleton:=true
 Bundle-Vendor: Eclipse.org
-Bundle-Version: 1.2.300.qualifier
+Bundle-Version: 1.2.400.qualifier
 Bundle-Localization: plugin
 Export-Package: org.eclipse.pde.bnd.ui.autocomplete;version="1.0.0";x-friends:="org.eclipse.pde.ui",
  org.eclipse.pde.bnd.ui.plugins;x-internal:=true,
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Test Results

   765 files  + 13     765 suites  +13   54m 45s ⏱️ + 5m 42s
 3 611 tests ±  0   3 557 ✅ +  1   54 💤 ±0  0 ❌  - 1 
10 833 runs  +194  10 670 ✅ +188  163 💤 +7  0 ❌  - 1 

Results for commit 398c215. ± Comparison against base commit b584f1d.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor

vogella commented Oct 7, 2025

+1

@BeckerWdf
Copy link
Contributor Author

@HannesWell: Can you pls. merge if this change is ok?

@vogella vogella merged commit b4eeb39 into eclipse-pde:master Oct 8, 2025
19 checks passed
@vogella
Copy link
Contributor

vogella commented Oct 8, 2025

@HannesWell: Can you pls. merge if this change is ok?

Sorry, did not see this comment. I can revert, if the approval from @HannesWell should be awaited

@BeckerWdf
Copy link
Contributor Author

BeckerWdf commented Oct 8, 2025

@vogella: I wasn't aware that you also have committer rights on PDE. I was just looking for somebody that is a PDE committer.
Thanks for merging.

@BeckerWdf BeckerWdf deleted the bnd_ui_unused branch October 8, 2025 06:38
@merks
Copy link
Contributor

merks commented Oct 8, 2025

Yes, I was going to merge this as well, but I see it's done.

@HannesWell
Copy link
Member

Can you pls. merge if this change is ok?

For me it's fine. The project org.eclipse.pde.bnd.ui is quite new so I don't expect (m)any external references to it. If a third-party wants to use these icons, they are better embedded in that bundle.

Thanks for that clean-up and sorry for the slow response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants