Properly encode filter string in feature editor#1957
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Sep 4, 2025
Merged
Properly encode filter string in feature editor#1957laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Currently if one uses a filter in a feature import that happens to use special characters like '&' that require encoding as an entity saving the feature will break the XML as it will write out the literal value but not the encoded entity. One then has to manually fix up the results. This now uses the PDEXMLHelper.getWritableAttributeString to properly encode this as and attribute value before writing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if one uses a filter in a feature import that happens to use special characters like '&' that require encoding as an entity saving the feature will break the XML as it will write out the literal value but not the encoded entity. One then has to manually fix up the results.
This now uses the PDEXMLHelper.getWritableAttributeString to properly encode this as and attribute value before writing.