Skip to content

Support more fragment options in DependencyManager / unify LaunchHelper#1960

Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi:unify_options_handling
Sep 6, 2025
Merged

Support more fragment options in DependencyManager / unify LaunchHelper#1960
laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi:unify_options_handling

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Sep 6, 2025

Currently one can only choose to include all fragments or only non-test fragments. But we can already distinguish several other types of fragments, e.g. those that belong to extensible API or provide native code specialization.

This now enhances DependencyManager to support a new type (INCLUDE_PLATFORM_FRAGMENTS) and to make configurable the inclusion of extensible API (INCLUDE_EXTENSIBLE_FRAGMENTS). Also the BundleLauncherHelper was adjusted to be more uniform when handling plugin versus feature based launches reading and preparing for further customization through launch configs.

@github-actions
Copy link

github-actions bot commented Sep 6, 2025

Test Results

  618 files   -   147    618 suites   - 147   48m 29s ⏱️ - 4m 34s
3 611 tests ±    0  3 556 ✅ ±    0   54 💤 ± 0  1 ❌ ±0 
8 183 runs   - 2 650  8 043 ✅  - 2 626  139 💤  - 24  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit f9b4a29. ± Comparison against base commit 18b020c.

♻️ This comment has been updated with latest results.

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Sep 6, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
ui/org.eclipse.pde.ui.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 5ce4500da568e32ff0ab0d9c61596517a935199c Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sat, 6 Sep 2025 12:22:39 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
index 96c71c496a..dfe922f1a2 100644
--- a/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: PDE JUnit Tests
 Bundle-SymbolicName: org.eclipse.pde.ui.tests; singleton:=true
-Bundle-Version: 3.13.200.qualifier
+Bundle-Version: 3.13.300.qualifier
 Bundle-ClassPath: tests.jar
 Bundle-Vendor: Eclipse.org
 Require-Bundle: org.eclipse.pde.ui,
diff --git a/ui/org.eclipse.pde.ui.tests/pom.xml b/ui/org.eclipse.pde.ui.tests/pom.xml
index 3a708274ba..d88dc2ab4f 100644
--- a/ui/org.eclipse.pde.ui.tests/pom.xml
+++ b/ui/org.eclipse.pde.ui.tests/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.pde.ui.tests</artifactId>
-  <version>3.13.200-SNAPSHOT</version>
+  <version>3.13.300-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@laeubi laeubi force-pushed the unify_options_handling branch 4 times, most recently from 60c5567 to 273d109 Compare September 6, 2025 12:18
Currently one can only choose to include all fragments or only non-test
fragments. But we can already distinguish several other types of
fragments, e.g. those that belong to extensible API or provide native
code specialization.

This now enhances DependencyManager to support a new type
(INCLUDE_PLATFORM_FRAGMENTS) and to make configurable the inclusion of
extensible API (INCLUDE_EXTENSIBLE_FRAGMENTS). Also the
BundleLauncherHelper was adjusted to be more uniform when handling
plugin versus feature based launches reading and preparing for further
customization through launch configs.
@laeubi laeubi force-pushed the unify_options_handling branch from eba9304 to f9b4a29 Compare September 6, 2025 12:55
@laeubi laeubi merged commit bcbeb9c into eclipse-pde:master Sep 6, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants