Skip to content

Add implicit requirements in TestSuiteHelper.addAllRequired#1977

Merged
akurtakov merged 2 commits intoeclipse-pde:masterfrom
merks:pr-missing-dependencies
Oct 2, 2025
Merged

Add implicit requirements in TestSuiteHelper.addAllRequired#1977
akurtakov merged 2 commits intoeclipse-pde:masterfrom
merks:pr-missing-dependencies

Conversation

@merks
Copy link
Contributor

@merks merks commented Oct 2, 2025

  • The algorithm only considers bundle requirements so the new Require-Cpability in org.eclipse.core.contenttype misses dependencies causing resolution errors that fail some tests.

eclipse-platform/eclipse.platform#2162

merks and others added 2 commits October 2, 2025 16:01
- The algorithm only considers bundle requirements so the new
Require-Cpability in org.eclipse.core.contenttype misses dependencies
causing resolution errors that fail some tests.

eclipse-platform/eclipse.platform#2162
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
apitools/org.eclipse.pde.api.tools.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 201726e7d14cc2d65b47c0de3de73c8fe1fff405 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Thu, 2 Oct 2025 14:10:57 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
index 467c0a1e4a..44f7b5ef1e 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.pde.api.tools.tests
-Bundle-Version: 1.4.200.qualifier
+Bundle-Version: 1.4.300.qualifier
 Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.pde.api.tools;bundle-version="1.0.600",
diff --git a/apitools/org.eclipse.pde.api.tools.tests/pom.xml b/apitools/org.eclipse.pde.api.tools.tests/pom.xml
index 143fb31ad0..dcc34f6ab4 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/pom.xml
+++ b/apitools/org.eclipse.pde.api.tools.tests/pom.xml
@@ -18,7 +18,7 @@
 		<relativePath>../../</relativePath>
 	</parent>
 	<artifactId>org.eclipse.pde.api.tools.tests</artifactId>
-	<version>1.4.200-SNAPSHOT</version>
+	<version>1.4.300-SNAPSHOT</version>
 	<packaging>eclipse-test-plugin</packaging>
 	<properties>
 		<defaultSigning-excludeInnerJars>true</defaultSigning-excludeInnerJars>
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results

   765 files  + 13     765 suites  +13   1h 3m 38s ⏱️ + 19m 9s
 3 611 tests ±  0   3 556 ✅ +  5   54 💤 ±0  0 ❌  -  5  1 🔥 ±0 
10 833 runs  +194  10 667 ✅ +197  163 💤 +7  0 ❌  - 11  3 🔥 +1 

For more details on these errors, see this check.

Results for commit f5f392f. ± Comparison against base commit 3347d35.

@merks
Copy link
Contributor Author

merks commented Oct 2, 2025

I see only the one test failure now so this PR does fix 3 of the test failures:

image

@akurtakov
Copy link
Member

Merging as these tests have been failing for far too long!

@akurtakov akurtakov merged commit f63768b into eclipse-pde:master Oct 2, 2025
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants