Skip to content

[Work in Progress] Issue #1858 [manifest editor] Show uses of exported packages in a tree. #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Work in Progress] Issue #1858 [manifest editor] Show uses of exported packages in a tree. #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/TreeSection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ protected void handleSelectAll() {
if (tree == null) {
return;
}

tree.selectAll();
selectionChanged(viewer.getStructuredSelection());
}
}
}
6 changes: 3 additions & 3 deletions ....pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExportPackageVisibilitySection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
import org.eclipse.jface.action.Action;
import org.eclipse.jface.action.IMenuManager;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.IStructuredContentProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.ITableLabelProvider;
import org.eclipse.jface.viewers.ITreeContentProvider;
import org.eclipse.jface.viewers.LabelProvider;
import org.eclipse.jface.viewers.StructuredSelection;
import org.eclipse.jface.viewers.TableViewer;
Expand Down Expand Up @@ -74,9 +74,9 @@
private Image fImage;
private Button fVisibleButton;

static class TableContentProvider implements IStructuredContentProvider {
static class TreeContentProvider implements ITreeContentProvider {

Check warning on line 77 in ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExportPackageVisibilitySection.java

View check run for this annotation

Jenkins - eclipse-pde / Compiler

Member 

ERROR:
The type ExportPackageVisibilitySection.TreeContentProvider must implement the inherited abstract method ITreeContentProvider.hasChildren(Object)

Check warning on line 77 in ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExportPackageVisibilitySection.java

View check run for this annotation

Jenkins - eclipse-pde / Compiler

Member 

ERROR:
The type ExportPackageVisibilitySection.TreeContentProvider must implement the inherited abstract method ITreeContentProvider.getElements(Object)

Check warning on line 77 in ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExportPackageVisibilitySection.java

View check run for this annotation

Jenkins - eclipse-pde / Compiler

Member 

ERROR:
The type ExportPackageVisibilitySection.TreeContentProvider must implement the inherited abstract method ITreeContentProvider.getParent(Object)
@Override
public Object[] getElements(Object parent) {
public Object[] getChildren(Object parent) {
ExportPackageObject object = (ExportPackageObject) parent;
if (object == null || !object.isInternal()) {
return new Object[0];
Expand Down Expand Up @@ -137,7 +137,7 @@
tablePart.setEditable(model != null && model.isEditable());
createViewerPartControl(container, SWT.MULTI, 2, toolkit);
fFriendViewer = tablePart.getTableViewer();
fFriendViewer.setContentProvider(new TableContentProvider());

Check warning on line 140 in ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExportPackageVisibilitySection.java

View check run for this annotation

Jenkins - eclipse-pde / Compiler

Type 

ERROR:
TableContentProvider cannot be resolved to a type
fFriendViewer.setLabelProvider(new TableLabelProvider());
toolkit.paintBordersFor(container);

Expand Down
Loading