Skip to content

Migrate ds tests to junit5#1995

Closed
vogella wants to merge 2 commits intomasterfrom
migrate-ds-tests-to-junit5
Closed

Migrate ds tests to junit5#1995
vogella wants to merge 2 commits intomasterfrom
migrate-ds-tests-to-junit5

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Oct 7, 2025

No description provided.

Creating a new class via the "Class URI" link in the E4 application
model
editor threw a ClassCastException due to an invalid type conversion in
the
data binding configuration of AbstractNewClassPage.java.

The target-to-model UpdateValueStrategy was missing a converter to
transform
the String value from the text field into an IPackageFragmentRoot,
leading
to a failed cast by the default converter.

This change introduces StringToPackageFragmentRootConverter to properly
map String paths to IPackageFragmentRoot instances and integrates it
into
the data binding setup. Users can now open the new class wizard and
create
handler classes without errors.
@vogella vogella closed this Oct 7, 2025
@vogella vogella deleted the migrate-ds-tests-to-junit5 branch October 7, 2025 19:12
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7434514f18e550e491f86f8508f2fd1db22a070a Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Tue, 7 Oct 2025 19:16:24 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF
index 150799019e..83050c5c9c 100644
--- a/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.ds.tests
-Bundle-Version: 1.3.400.qualifier
+Bundle-Version: 1.3.500.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ds.tests.Activator
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.pde.core;bundle-version="[3.3.0,4.0.0)",
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants