Skip to content

Validate document availability after connect() to diagnose null document NPE #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Validate document availability after connect() to diagnose null document NPE #2019

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4cac43
Initial plan
Copilot Oct 14, 2025
777c86c
Add null checks to prevent NPE when opening MANIFEST.MF
Copilot Oct 14, 2025
6e9180a
Update null handling approach - allow model creation with null document
Copilot Oct 14, 2025
323d771
Validate document availability after connect() to provide better error
Copilot Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/context/InputContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,16 @@ protected void create() {
fDocumentProvider = createDocumentProvider(fEditorInput);
try {
fDocumentProvider.connect(fEditorInput);
// Verify that the document is available after connect()
// This can fail if the file was deleted/moved during editor initialization
// or if there's a race condition with workspace events
IDocument document = fDocumentProvider.getDocument(fEditorInput);
if (document == null) {
throw new CoreException(new org.eclipse.core.runtime.Status(
org.eclipse.core.runtime.IStatus.ERROR,
"org.eclipse.pde.ui", //$NON-NLS-1$
"Document not available after connecting to document provider for input: " + fEditorInput.getName())); //$NON-NLS-1$
Comment on lines +170 to +173
Copy link
Member

@HannesWell HannesWell Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this substantially improve the situation? To me it seems like we are not trading a NullPointerException for a a CoreException?

Copy link
Member

@HannesWell HannesWell Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore calling the new Status constructor can be replaced by the simpler Status.error() factory:

Suggested change
throw new CoreException(new org.eclipse.core.runtime.Status(
org.eclipse.core.runtime.IStatus.ERROR,
"org.eclipse.pde.ui", //$NON-NLS-1$
"Document not available after connecting to document provider for input: " + fEditorInput.getName())); //$NON-NLS-1$
throw new CoreException(Status.error("Document not available after connecting to document provider for input: " + fEditorInput.getName())); //$NON-NLS-1$

}
fModel = createModel(fEditorInput);
if (fModel instanceof IModelChangeProvider) {
fModelListener = e -> {
Expand Down
Loading