Support SVG icons in extension point editor

[Dani-Hub]

Add "svg" to list of supported file extensions for images

[Dani-Hub]

Can someone please help me with the ECA problem? I logged in again and revalidated my ECA but it still does not validate here. Have recently the commit rules changed? Is my commit text incomplete?

[HannesWell]

Thank you for your contribution.

Can someone please help me with the ECA problem? I logged in again and revalidated my ECA but it still does not validate here.

This is indeed a bit strange as the ECA overview page also shows your mail validated once but four times as not validated and it looks like the same mail:
https://api.eclipse.org/git/eca/status/gh/eclipse-pde/eclipse.pde/2026

Have recently the commit rules changed? Is my commit text incomplete?

Actually not. But your three commits, including a merge commit seem to be a bit strange and maybe this confuses the tool.
Please squash your change in one commit, with a meaningful message. Ideally the message references the issue by its full URL. E.g. at the end using:

Fixes https://github.com/eclipse-pde/eclipse.pde/issues/2025

Then rebase that commit on top of the current master and force push it to the branch of this PR to update it.

Thanks in advance.

[HannesWell]

Since you are touching that line anyways, could you also modernize it by using a List?

Suggested change

	private static final String[] VALID_IMAGE_TYPES = {"png", "bmp", "ico", "gif", "jpg", "tiff", "svg"}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$
	private static final List<String> VALID_IMAGE_TYPES = List.of("png", "bmp", "ico", "gif", "jpg", "tiff", "svg"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$

[Dani-Hub]

I'm not so familar with squashing, therefore I decided to close this puull request in favour for a new one (#2030)

[HannesWell]

I'm not so familiar with squashing, therefore I decided to close this pull request in favour for a new one (#2030)

Please try to avoid it for future contributions as this causes extra noise and makes it harder to follow discussions if they are distributed over multiple PRs.

You can squash existing PRs with EGit for example in the History view of Eclipse using the context menu. Just select the consecutive commits you want to squash, right-click on them and select via Modify -> Squash:

Alternatively/additionally you can also Amend an existing commit in EGit's Git staging view:

And to force push you can for example select the corresponding check-box in the EGit push dialog (the details depend a bit on your exact workflow):

On the CLI you can of course push with --force/-f.

Don't hesitate to ask if you have more questions :)

[Dani-Hub]

Thanks very much about the explanation about squashing! Btw.: I actually did amend all my original commits of my first pull request, I'm surprised that it appeared as individual commits to you. Anyway, the problem is now solved, thanks again for your support!