Centralize code used in two places to compute JUnit requirements#2044
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Oct 23, 2025
Merged
Centralize code used in two places to compute JUnit requirements#2044laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
laeubi
force-pushed
the
extract_into_shared_class
branch
4 times, most recently
from
f748967 to
e2b145f
Compare
Currently we have almost identical code in JUnitLaunchConfigurationDelegate and JUnitPluginLaunchConfigurationDelegate to compute the JUnit requirements. This now extract the code into a central place JUnitLaunchRequirements for consistency and maintenance. Co-authored-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
laeubi
force-pushed
the
extract_into_shared_class
branch
from
e2b145f to
9050251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have almost identical code in JUnitLaunchConfigurationDelegate and JUnitPluginLaunchConfigurationDelegate to compute the JUnit requirements.
This now extract the code into a central place JUnitLaunchRequirements for consistency and maintenance.
This is NOT modify anything, it just uses the code as-is to prepare for
so we can get an actual diff of what this PR changes!
So after this is merged, the PR can be rebased and the content of the file
ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/JUnitLaunchRequirements.javais simply replaced and should then result in a usable diff of actual changes.